multipart send/recv #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know an easier way to get a C buffer without using NSData. I think ZMQ will free the buffer for us, so we don't have to worry about that? I'm pretty sure `string.characters.count` in the existing implementation is dangerous: surely it will do the wrong thing for wide chars!
|
Awesome. Just a couple of comments for it to get merged. Please add a |
|
@tjvr Any update on this one? |
Apparently this will handle failures & prevent memory leaks. :-)
|
@azawawi Like this? :) |
|
Thanks 👍 |
|
Cheers! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya! Just a couple methods I found useful—I need to work with multipart messages, which seems like it'd be a good addition to the Swifty library.
Let me know if this is useful to you too—no obligation to merge it! :)
Have a nice day,
Tim