fix(CI): fix ubuntu-24.04 build #18984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudlud
changed the title
sudlud
added
To Be Merged
Ready to be Reviewed
run-build
55Honey
approved these changes
Jun 1, 2024
ikkj
pushed a commit
to ikkj/AzerothCore-wotlk-with-NPCBots
that referenced
this pull request
Jun 10, 2024
fix(CI): try to fix ubuntu-24.04 build
ikkj
pushed a commit
to ikkj/AzerothCore-wotlk-with-NPCBots
that referenced
this pull request
Jun 13, 2024
fix(CI): try to fix ubuntu-24.04 build
zTerragor
added a commit
to Legends-of-Azeroth/Legends-of-Azeroth-WoTLK-Core
that referenced
this pull request
Jun 26, 2024
* fix(DB/Gameobject): Rebuild all Eastern Kingdoms gathering nodes using sniffed data (#18898) * Create rev_1715713909070959500.sql * extra leftovers * chore(DB): import pending files Referenced commit(s): fd7c8a0bde61508c8654c7be92c9fc2be65d2ac2 * fix(Core/BattlegroundAV): spawn generic gameobjects in Alterac Valley (#18764) * fix(Scripts/PVP): correctly spawn generic gameobjects in Alterac Valley I've been "collecting" these in the DB for a while, now it's time to move these spawns to the AV script and actually spawn them. * add 2 additional generic gameobjects * chore(DB): import pending files Referenced commit(s): e2029c363323d8bde195a302b6934497b57197ba * fix(Scripts/ShadowmoonValley): minor fixes to Enslaved Netherwing Drakes (#18883) * init * fixes * fix(CI): revert ubuntu-22.04 to gcc12 (#18905) * fix(CI/PCH): revert ubuntu-22.04 to gcc12, add ubuntu-24.04 with gcc14 * also update nopch workflow * Update core-build-nopch.yml * Update core-build-pch.yml * feat(CI): add CI for ubuntu-24.04 (#18909) * fix(DB/creature_text): localize Arcanist Braedin txt line about WG (#18886) * chore(DB): import pending files Referenced commit(s): 4ae69cf01b5cdf6ddff33b9a44f55ea9785ca97b * feat(core): add hooks for applying item mods (#18760) * feat(Scripts/Commands): Add quality colors to .item lookup command (#18907) add quality colors to .item lookup command * chore(DB): import pending files Referenced commit(s): 49e3d5dfff5ec339485272d3c41c2d84daa45747 * chore(Docker): update docker compose file schema (#18686) * fix(Docker): Check write access for config dir (#18238) * fix(DB/creature_text) add missing broadcastID to Elder Clearwater txt lines to supp… (#18917) * (DB/SQL)add missing broadcastID to Elder Clearwater txt lines to support localization * Update kaluac.sql * chore(DB): import pending files Referenced commit(s): 64833d965f1f59d580d5ce674c4847afb7cfd368 * fix(DB/Gameobject): Sniffed Values for 'Crossroads' Supply Crates' spawns (#18904) * chore(DB): import pending files Referenced commit(s): cf8c1557555d2c0d2a034c8613397fd18cc65b9a * fix(CI): bump dependencies for usage of Node.js 20 (#18914) * fix(DB/Creature): Correct TBC boss gold rewards. (#18899) * Init. * Remove auxiliary comments. * Readd comments along with original reward values. * Remove auxiliary comments again. * Add important commit regarding data accuracy. * Move comment. * chore(DB): import pending files Referenced commit(s): 346456f78f0981e3b48d2ed93da02d46a679295a * fix(Scripts/Commands): Fix .lookup item command for most locales (#18922) follow-up to 49e3d5d * fix(Scripts/Ulduar): disable Mimiron's and Thorim's Targetting crystal when talking to Bran (#18927) load Mimiron's and Thorim's Targetting crystal * fix(Scripts/Hyjal): Limit Anetheron sleep to 3 targets (#18929) * fix(Scripts/Hyjal): Archimonde shouldn't cast other spells during enr… (#18928) fix(Scripts/Hyjal): Archimonde shouldn't cast other spells during enrage/outro * chore(DB): import pending files Referenced commit(s): 0aaf5214239ebdb0bf491acf4a20aff52b48816a * fix(Scripts/Hyjal): Air Burst should not be cast on MT (#18933) * fix movement of doomfire * fix air burst * conditions * movechase random target * Update boss_archimonde.cpp * update movement * Update boss_archimonde.cpp * Update boss_archimonde.cpp * chore(DB): import pending files Referenced commit(s): f78820e9d58e9cd8a8f7b6234d94bce5d8a0c1d5 * fix(Scripts/Hyjal): initialize/reset local private variables in Reset function (#18932) initial * chore(Scripts/Hyjal): Don't initialize headers twice (#18939) * fix(Scripts/Ulduar): update Boss Keepers, Gossip Keepers, Yogg Keepers, Yogg-Saron (#18943) * gossip keepers, keepers, sara freya spell improvements better gossip update converter to update spellscript refactor sanity wells spawn position, summons zonecombat make sara summon sanity wells again thorim casts start again, handle sanity wells only by sanity well spawn script refactor sanity brackets update comment gossip keepers, keepers, sara freya spell improvements better gossip update converter to update spellscript refactor sanity wells spawn position, summons zonecombat make sara summon sanity wells again thorim casts start again, handle sanity wells only by sanity well spawn script refactor sanity brackets update comment gossip keepers, keepers, sara freya spell improvements better gossip update converter to update spellscript refactor sanity wells spawn position, summons zonecombat make sara summon sanity wells again thorim casts start again, handle sanity wells only by sanity well spawn script refactor sanity brackets update comment gossip keepers, keepers, sara freya spell improvements better gossip update converter to update spellscript refactor sanity wells spawn position, summons zonecombat make sara summon sanity wells again thorim casts start again, handle sanity wells only by sanity well spawn script refactor sanity brackets update comment * refactor: remove _keepersGUID[4] * make keeper auras only target players, remove apply scale immunity to well/keepers include caster in cast * update keeper flags * summon and despawn gossip keepers spawn only if fight done add intro spell and handle outro fix off by 1 fix casting simple teleport, only spawn after teleporting remove empty line * add teleport to shared ulduar.h * each keeper triggers their own gossip spawn * update is called in Reset(), no need to do it here * add SpellHit override to Freya, Hodir * Freya, Hodir: use scheduler to schedule post-fight teleport * JustSummoned rename cr to summon * sanity well summons are handled by freya instead of sara * rename pCreature to creature * keeper use RegisterUlduarCreatureAI * Freya, Hodir, Thorim: increase despawn time * despawn tentacles, sanity wells after fight despawn tentacles after fight * change order of teleport spells * am missing header? * chore(DB): import pending files Referenced commit(s): 845fa07aad883db4c11f62cdbab82cb8fe6a1913 * fix(DB/Loot): Fix mistake in generic overworld profession drops (#18941) * Create oopsmybad.sql * Update oopsmybad.sql * Update oopsmybad.sql * chore(DB): import pending files Referenced commit(s): 88c485f6c54d45d05d638e38126c4d57c5071f5a * fix(Scripts/Ulduar) Kologarn becomes a bridge (#18944) * disable_move is already set in unit_flags creature template * make kolo not selectable, disable gravity on death * fix(Scripts/Ulduar): Add emote for opening of the Ancient Gate of the Keepers (#18949) add ancient gate emote * fix(ICC/Sindragosa): add a cooldown to proccing Unchained Magic (#18901) * add cooldown to proc * convert to spell and aurascript pair macro * remove no longer needed validate override * set cooldown with Cooldown field in table spell_proc_event * chore(DB): import pending files Referenced commit(s): 29dda79638604fc0626f76d5158085baa8327d5b * fix(Scripts/Ulduar): falling down Kologarn's pit should kill (#18945) * add insersectboundary * add kill bunny to kologarn's pit * Update data/sql/updates/pending_db_world/rev_1716571588345702920.sql Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com> * refactor: use Map DoForAllPlayers --------- Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com> * chore(DB): import pending files Referenced commit(s): 99004116a594bf2f8d76fc7248f6e8130f4a5a40 * fix(Scripts/Ulduar): adjust Mimiron outro RP sleep visuals (#18950) * fix the sleep visual, add stand up event * make Mimi selectable during outro so you can see his faction change * talk with emote oneshot talk * fix selectable * adjust timings * set done status when chest spawns * combat should stop when Mimiron ejects * Revert "combat should stop when Mimiron ejects" This reverts commit 6e476a55a49c33109f9112b2782d0d186eef49f3. * style * fix(Scripts/Hyjal): Azgalor Rain of Fire should target non-player tar… (#18956) fix(Scripts/Hyjal): Azgalor Rain of Fire should target non-player targets * chore(Scripts/Hyjal): Update Mark of Kazrogal script (#18958) * Fix creatures combat AI missing (#18947) * add sql * add 18850 fix * fix * Modify the commnet * chore(DB): import pending files Referenced commit(s): 8200385efb40852413f0d056bcfa667536ae233f * fix(Scripts/Hyjal): Anetheron should not cast sleep on MT (#18948) * init * also talk when spell fails * fix(Scripts/Hyjal): Azgalor mark of doom spawn demons on target death (#18959) * chore(DB): import pending files Referenced commit(s): 73e44859f075321bb53023e48aa13f717f321098 * fix(Scripts/IcecrownCitadel): Gunship Cannons generates heat on Cast not on Hit (#18805) * Update boss_icecrown_gunship_battle.cpp Makes the Cannons on Gunship Blizzlike. They generate power (heat) on cast and not on Hit. Removes Engergize from Spell 69399 cause its only triggers on target->hit in core Still uses spellscript effect but on cast instead * Update boss_icecrown_gunship_battle.cpp * fix(Scripts/Hyjal): Implement Eternal Silence spell when going into t… (#18960) fix(Scripts/Hyjal): Implement Eternal Silence spell when going into the Well of Eternity * chore(DB): import pending files Referenced commit(s): 2a1d23e520547c802172e1cae31320607709dd98 * fix(Ulduar/Tram): add rocket booster, turnaround visuals, button logic (#18900) fix(Ulduar/Tram): add rocket booster, disable logic, activate turnaround gobjects remove go_call_tram GameObjectScript add tram gobjects to header add tram logic renames update position of boosters * chore(DB): import pending files Referenced commit(s): 733fbf89e130fbad9fdd933e8c3d8b5e171f5cf0 * fix(Scripts/Hyjal): Azgalor doom shouldnt target tank MKII (#18964) * fix(Scripts/Hyjal): Fix Doom spawning Doomguards twice on expire (#18968) * fix(Scripts/Hyjal): Anetheron dont cast sleep on tank (#18969) * fix(Scripts/Hyjal): tweak movement of Doomfire (#18970) initial * chore(DB): import pending files Referenced commit(s): fe6137b0a07b754d24070911da4d3905cc48c366 * fix(LICENSE): update license file paths (#18972) Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> * fix(Unit/ProcessTerrainStatusUpdate): prevent removal swimming auras if swimming (#18902) * do not remove swimming auras if we are swimming * refactor to isSwimming() * Update src/server/game/Entities/Unit/Unit.cpp Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com> --------- Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com> * fix(Scripts/Hyjal): remove summoned mobs on boss evade and reset waves (#18975) init * fix(Scripts/Hyjal): increase ranges on doomfire to make movement less inclined to stick close to the boss (#18976) initial * fix(CI): fix ubuntu-24.04 build (#18984) fix(CI): try to fix ubuntu-24.04 build * fix(Scripts/Hyjal): fix some build warnings for unused parameters (#18986) * fix(CI): bump pr-labeler dependencies for usage of Node.js 20 (#18983) this workflow currently has the warning: ``` Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/labeler@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. ``` * fix(DB/Creature): Couple Netherwing related fixes. (#18981) * Init. * Update. * chore(DB): import pending files Referenced commit(s): 1d664870d2a04bcbe69e4c82233fdc1c8bace544 * fix(CI): fix labeler (#18990) * fix(CI): I think this fixes the labeler :D * Update labeler.yml * Update pr_labeler.yml * Update labeler.yml * test complete - this should work after merge * Update labeler.yml * fix(Core/Mail): calculate unReadMails and m_nextMailDelivereTime usin… (#18996) * fix(Core/Mail): calculate unReadMails and m_nextMailDelivereTime using mail cache - these values were grepped directly from DB before -> this change was introduced with azerothcore/azerothcore-wotlk#3420 - the whole mailing system relies on the mails beeing cached in the core -> these get stored in DB regularly or on specific events - so apparently the DB is not always in sync with the current mail cache state of the core -> so grepping data directly from DB is not a good idea at this point * Update PlayerUpdates.cpp * fix(DB/achievement_reward): award title on Hand of A'dal FoS (#18998) * init * oops * fix(Scripts/Hyjal): correctly despawn summoned creatures on Jaina/Thrall death (#18997) * init * change logic despawning of bosses is not really done the normal way, but it's forced with a set amount of guids. So we simply need to register the summons as guids as well * small fixes * Delete creature_scripts.sql * Update boss_azgalor.cpp * chore(DB): import pending files Referenced commit(s): a0b942332b1ababd8ffdcdb26a1188d64a049b67 * fix(Script/Hyjal): Fix encounter states not reseting if bosses are de… (#19000) * fix(Script/Hyjal): Fix encounter states not reseting if bosses are despawned while in combat * Update instance_hyjal.cpp * fix(Core/PetHandler): when dismissing a charmed unit owned by another unit; stop the charm instead of despawning (#18989) https://github.com/TrinityCore/TrinityCore/commit/2cdea49d81ce2bb4e19df594c019a42fb4ba0c5b * fix(Scripts/Hyjal): archimonde enrage after 10 minutes (#19003) init * fix(Scripts/Hyjal): Anetheron cast Carrion Swarm on non player targets (#19005) * chore(Scripts/Hyjal): Clean up unsafe calls and code style (#19004) * chore(Scripts/Hyjal): Clean up unsafe calls and code style * another one * chore(CI): drop checks - only keep latest Ubuntu 24.04 (#18991) * chore(CI): Nuke 20.04 checks * revert back to old where we dont test gcc on pch * only test latest version. Keep it up to date folks * fix(Core/PlayerQuest): make timed quests failable (#18940) * fix(Core/Battleground): Adjust Eye of the Storm tick rate. (#19007) * fix(CI): add missing ticks to labeler.yml file paths (#18995) * fix(Core/Networking): Fix crash in Proxy Protocol when removing closed sockets. (#19011) * fix(Scripts/Hyjal): Fix Azgalor Doom targetting tanks since its an AoE spell (#19012) * fix(Scripts/Hyjal): Fix Azgalor Doom targetting tanks since its an AoE spell * Update boss_azgalor.cpp * fix(Script/Item): Fetch Ball (#18906) * refactor use enum for spellIds * add sql * update sql * enclose Comment with backticks ` * Closes https://github.com/azerothcore/azerothcore-wotlk/issues/565 * chore(DB): import pending files Referenced commit(s): a1ddf6d520b8aa46133d657338ab47b06eb2fd8c * fix(Core/Player): Delete by group (#19015) * fix(Core/Player): Delete by group * closes https://github.com/azerothcore/azerothcore-wotlk/issues/19014 Co-Authored-By: trickerer <onlysuffering@gmail.com> * Update Player.cpp * fix build --------- Co-authored-by: trickerer <onlysuffering@gmail.com> * fix(CI/labeler): fix some paths for proper labeling (#19016) * fix(Scripts/HallsofStone): corrected Brann dialogue to match live game (#19019) * fix(Scripts/Halls of Stone): corrected Brann dialogue to match live game * fix(Scripts/Halls of Stone): corrected Brann dialogue to match live game * fix(DB/Stratholme): add Magistrate Barthilas escape event in Stratholme (#17669) * 1. Added Magistrate Barthilas escape event 2. Fighting the Magistrate Barthilas at the entrance will close the 2 gates leading to the plaza 3. A fight in the slaughterhouse will close the door to the side of the slaughterhouse and will not open until a fight with baron Rivendare 4. Associate some conversation text to Broad*castTextId 5. Added an action for the player to stand up - turn around - salute when the player approaches Aurius 6. Added combat AI to Aurius to prepare for the event where Aurius helps players kill baron Rivendare * Error in SQL statements is fixed * Fixed Magistrate Barthilas not turning into human form when he died. Transfiguration should be used on himself * Fix a misspelling in a note * fix error * Save the status of the escape event to the database * Remove spaces * Modify the code formatting * enum format restore * Modify the enum * Delete data/sql/updates/pending_db_world/斯坦索姆 fix.sql Delete files that were accidentally pushed * fix "Grand Crusader Dathrohan" Unable to speak when transforming and dying and the worldserver console error * 1 waypoint 1 plus 1s suspension time. 2 Transmission data plus map number. * The door to the slaughterhouse is opened when there is a player dying and all players in the party are not in combat * Remove spaces and add comments * Change as requested * Update data/sql/updates/pending_db_world/rev_1699566747105058500.sql Test if this button can be updated directly Co-authored-by: KJack <kgithub@kellerg.com> * Use the full sniffing path * fix error * edit * Moved the escape time to smartscript Delete the closed door * Remove spaces * Fixed where barthilas were not in the slaughterhouse after moving to near the slaughterhouse after the save location was restarted * Delete unused classes --------- Co-authored-by: KJack <kgithub@kellerg.com> * chore(DB): import pending files Referenced commit(s): 0abc66e57d3cbeffd14afcd9f7d4b753cf54432a * fix(DB/achievement_reward): Glory of the Ulduar Raider mail subject line (#19018) * chore(DB): import pending files Referenced commit(s): 906ec60debd5093ea26ed95b9578680734b2a00b * fix(DB/Item): Egg Basket (#19021) * Closes https://github.com/azerothcore/azerothcore-wotlk/issues/18903 * fix(DB/Gameobject): Rebuild all Kalimdor gathering nodes using sniffed data (#18982) Co-authored-by: sudlud <sudlud@users.noreply.github.com> Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com> Co-authored-by: neifion-00000000 <91289495+neifion-00000000@users.noreply.github.com> * chore(DB): import pending files Referenced commit(s): 3837f67eafd66d1b23797963f5e7338885acc6a1 * fix(Scripts/HyjalSummit): Assign Death Knight Soul Charge. (#19020) Init. Alphabetize and correct DK soul charge assign. * fix(Scripts/Hyjal): Change the spawn and the movement of Doomfire (#19027) * Doomfire_spirit_speed * Update boss_archimonde.cpp * Rename * chore(DB): import pending files Referenced commit(s): eed20b4647fb890bc980b55e8f9b2a94debe7c39 * fix(Scripts/Hyjal): some Archimonde fixes (#19031) * init * update spellscript * fix targetting * Update boss_archimonde.cpp * chore(DB): import pending files Referenced commit(s): bbb0cb43eb0d0574c9a019a0b01cfe71e04ef80b * fix(DB/Creature): Correct model info for Hyjal bosses. (#19032) * Init. * Remove comments. Bad CI. * chore(DB): import pending files Referenced commit(s): 299631f3b561fb63eb9aab8619663a20f76643fc * refactor(Scripts/Naxxramas): Spell Scripts use registry macros (#19034) * ktz frost blast * ktz detonate mana * thaddius pos_neg_charge * thaddius polarity shift * sapph frost explosion * grobbulus poison * grobbulus mutating injection * gothik shadow bolt volley * gluth decimate * horsemen mark * add sql * trigger ci * Revert "trigger ci" This reverts commit d8b18d5c5c37d12da1deab0be50941bfe96641a6. * add validate horsemen mark * add validate gluth decimate * add validate gothik shadow mark * add validate ktz frost blast * add validate thaddius pos_neg_charge * chore(DB): import pending files Referenced commit(s): 415f52d66263c3b3207e3dff925e8e5ffc643ad3 * chore(Command/unstuck) use command with offline players (#18913) Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com> Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com> * fix(DB/SAI): Subdue the Subduer should credit group (#19036) * fix(Scripts/Hyjal): Air Burst back to random target (#19037) init * chore(DB): import pending files Referenced commit(s): afd8cfef9486205472f7ac7c01d081e2d83e3305 * chore(Scripts/Hyjal): Clean up redundancy (#19035) * fix(DB/SAI): Watoosun Polluted Essence shouldnt cast Acid Splash (#19038) * chore(DB): import pending files Referenced commit(s): 8a988fd10a1adba402cb6db45d7385c81ff606f9 * fix:(DB/creatures) Repair the position of the chicken in Southshore (#19043) * Repair the position of the chicken in Southshore * Update rev_1718001686055216100.sql * fix(DB/Creature): Vashj elementals disorient immunity (#19042) * chore(DB): import pending files Referenced commit(s): 7a99e0ba82db88da2b632d701acdacb900b0b8be * fix(Scripts/SSC): Fix Serpentshrine Parasites not being summoned (#19041) * fix(DB/Creature): Crystalcore Sentinals & Devastators knockback immunity (#19040) * chore(DB): import pending files Referenced commit(s): 9ca9c2b651540a9395da826ffc3ec63b5e0ef7f7 * fix(Scripts/NPC): Fix arcanite dragonling attacking non flagged players (#19039) * fix(Scripts/Hyjal): remove very scary call by reference and posis without initialization (#19046) remove call by reference * refactor(Scripts/Ulduar): Spell Scripts use registry macros (#19045) * algalon phase punch * algalon collapse * algalon trigger 3 adds * algalon cosmic smash damage * algalon big bang * algalon remove phase * algalon supermassive fail * auriaya sentinel blast * ic shield of runes * ic assembly meltdown * ic rune of summoning * thorim lightning pillar * thorim trash impale * kologarn ulduar stone grip cast target * kologarn stone grip * kologarn squeezed lifeless * kologarn stone shout pair * mimiron rapid burst * mimiron laser barrage * ignis scorch * ignis grab initial * ignis slag pot * ulduar energy sap * ulduar arachnopod damage * xt tympanic tantrum * xt gravity bomb damage * xt gravity bomb pair * xt searing light spwan life spark pair * fl load into catapult * fl auto repair * fl systems shutdown * fl pursue * fl vehicle throw passenger * fl tar blaze * fl vehicle grab pyrite * fl vehicle circuit overload * fl orbital supports * fl thorims hammer * fl transitus shield beam * fl shield generator * fl demolisher ride vehicle * yogg malady of the mind * yogg brain_link pair * yogg shadow beacon * yogg destabilization matrix * yogg titanic storm * yogg lunatic gaze * yogg protective gaze * yogg empowered * yogg insane periodic trigger * yogg insane * yogg sanity well * yogg sanity reduce * yogg empowering shadows yogg empowering shadows * yogg in the mwas of the old god * yogg target selectors * yogg grim reprisal * add sql * fixup! algalon phase punch * fixup! algalon remove phase * fixup! ic assembly meltdown * vezax mark of the faceless periodic * vezax mark of the faceless drainhealth * vezax saronite vapors dummy * vezax saronite vapors damage * vezax aura of despair vezax aura of despair style vezax aura of despair add validate * vezax aura of despair add validate hasspell * Revert "vezax aura of despair add validate hasspell" This reverts commit fccf163399a12119fc468c2fe41ea0798a55eefc. * sort sql * chore(DB): import pending files Referenced commit(s): 77d57efdd1dd16ad477e3ecb5cab87a79a6f98d2 * fix(DB/Gameobject): unlink 'Mighty Blaze' spawns from game events (#19049) * chore(DB): import pending files Referenced commit(s): 29e747d9204457bab50ce24d924bf0e36db4a05d * fix(CI/labeler): update Core, Documentation, Cmake labelling (#19022) fix(CI/labeler: update Core, Documentation, Cmake labelling * fix(DB/Creature): Kadrak's wrong axe model (#19047) fix(DB/Creature): Kadrak's axe * fix(CI): reintroduce ubuntu-22.04 checks (#19052) - we wan to support the 2 latest ubuntu LTS versions * chore(DB): import pending files Referenced commit(s): 7441938bc36ac37f5641f009ed28375bd9c10d43 * fix(Core/Pet): Warlock pet handling (#19054) * dismiss summoned non-hunter pets by removing them * store createdbyspellid * Revert "dismiss summoned non-hunter pets by removing them" This reverts commit eb539e841d882a6c90f743792c91304b0d365a5c. * fix(docs): sync SECURITY.md with current CI config (#19057) * fix(DB/Creature): Reth'hedron spawn timer (#19055) * chore(DB): import pending files Referenced commit(s): 923ea9f29a5c6f1f3462afb917daa0c5a2b6dda8 * fix(DB/Creature): Aqueous Lord formation behaviour (#19064) fix(DB/Formations): Aqueous Spawn formation behaviour * fix(DB/Spell): Sludge Nova stack from different casters (#19063) * fix(DB/Creature): Aquaneous Lord taunt immunity (#19061) * chore(DB): import pending files Referenced commit(s): 28fae60efc157a6477c4d990fa15f6055e35ee2a * fix(DB/Item): Stormherald PPM adjustment. (#19059) Init. * feat(CI): enable fail-fast for pch/nopch (#19058) fix(CI): enable fail-fast for pch/nopch * chore(DB): import pending files Referenced commit(s): e98e03302e04a51b2637b9a08abfc5fc05f0c205 * fix(Scripts/BlackTemple): Fix Free Friend spell (#19065) * fix(Scripts/BlackTemple): Fix Najentus not enraging after 8 min (#19066) * fix(DB/Achievement): Pilgrim reward mail (#19067) * closes #18429 * chore(DB): import pending files Referenced commit(s): 9d882739768e0b2eba1e5ad96ad38cfde1799a07 * fix(Scripts/Spells): Flag of Ownership (#18757) Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com> * fix(Scripts/BlackTemple): Fix najentus enrage not reseting (#19074) * refactor(Core/ObjectMgr): Implement display probabilities. (#19068) * Init. Cherry-picked from TC commits https://github.com/TrinityCore/TrinityCore/commit/9d210476e57949094fdd286001ef4900564edca5 and https://github.com/TrinityCore/TrinityCore/commit/c488fb219ab080031488593a0b86ac785a7d2cae Co-Authored-By: Traesh <9392905+traesh@users.noreply.github.com> Co-Authored-By: Shauren <shauren.trinity@gmail.com> * Add brute data. Needs validation against what existed before, i.e. Classic change prevention. * Add validation info for brute data. * Remove incomplete data queries. * Requested changes. * Whitespace. * Requested change. Table name. Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com> * Requested change. Table name. Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com> * Resolve the funny merge conflicts. I wonder why git blame doesn't work on a file with 20k lines in it that's odd huh champ. * Remove unused parameter. * Remove uses of unused parameter. * Use unused parameter. Hopefully? * I will cry. * Sobbing endlessly. * Remove comment. * Adjust table structure query. Remove length parameters and allow null for build value. Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com> * Adjust column datatype and add check constraint. --------- Co-authored-by: Traesh <9392905+traesh@users.noreply.github.com> Co-authored-by: Shauren <shauren.trinity@gmail.com> Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com> * chore(DB): import pending files Referenced commit(s): d6d49a9e45e5eb59e06fe14d7e4107015fcc0e0e * fix(DB/Spells): Infinity Blade's Magic Disruption should stack for di… (#19077) fix(DB/Spells): Infinity Blade's Magic Disruption should stack for different casters * chore(DB): import pending files Referenced commit(s): cf258bc9696ab0d1547a016bbc57631d63145c3e * fix(Core/AI): Fix bosses being stuck IN_PROGRESS if despawnonevade fl… (#19070) fix(Core/AI): Fix bosses being stuck IN_PROGRESS if despawnonevade flag is used * fix(Scripts/Hyjal): Archimonde should gain charges regardless of deat… (#19069) * fix(Scripts/Hyjal): Archimonde should gain charges regardless of death cause * Update instance_hyjal.cpp * fix boss waves * fix(DB/Creature): Correct model info for Black Temple bosses. (#19079) * Init. * Consolidate, remove comments. * chore(DB): import pending files Referenced commit(s): 36621804b9732a16485fd85bde71a944464fdfb7 * fix(Scripts/ObsidianSanctum): add Flame Tsunami knockback (#19078) * refactor spellscript refactor spellscript * add flame tsunami knockback * chore(DB): import pending files Referenced commit(s): 3211c7d884a2eeba1949e7a5b7310f0bedfa77a3 * chore(Scripts/Hyjal): Remove unneeded Archimonde spell scripts (#19080) * chore(Scripts/Hyjal): Remove unneeded spell scripts * use trigger flags * Update boss_archimonde.cpp * Update boss_archimonde.cpp * chore(DB): import pending files Referenced commit(s): 5f966e8e0c7bb104949d5e06e47ad8e2d4237a2c * fix(Scripts/Misc) CanExecuteCommand renamed and moved to be executed for all commands. (#19081) * Fix CanExecuteCommand only being executed on command failure. * Updated for style guide. * Removed pointless hook call. * Modified the name of the hook to better reflect function and moved the call to trigger for non-existent commands. * Updated to OnTryExecuteCommand because Foe has a special place in my heart. * Forgot to change these 2 areas. * fix(Scripts/BlackTemple): Akama shade missing says (#19076) Co-authored-by: Keader <keader.android@gmail.com> * fix(Scripts/SlavePens): Rewrite Ahune. (#19075) * Add WPP SQL output. * Uncomment all entries. With one exception, one that does not exist in DB * Sort all by template entry. * Add reference names for templates. * Distinguish summons from static spawns. * Separate summons from static spawns in SQL parse. * Add timestamps and spell casts for creatures. * Init spawn query. * Init script stuff. * Init port work. Co-Authored-By: Gustavo <sirikfoll@hotmail.com> * Bad flag porting. * Update stand states and unit flags properly. * Adjust SQL. * Add birth spell. Properly shows the desired animation, to be verified through sniffs if he actually casts it. * Update Frozen Core model data. Collected from TC master branch. Will correct with proper data once sniff data becomes available. * Elaborate rhyme aura text functions. Co-Authored-By: sudlud <sudlud@users.noreply.github.com> * Adjust for structure changes. * Elaborate delete queries. --------- Co-authored-by: Gustavo <sirikfoll@hotmail.com> Co-authored-by: sudlud <sudlud@users.noreply.github.com> * chore(DB): import pending files Referenced commit(s): 4b5468face38ca051cf4ba010c1628651cc41d72 * fix(core/spell): Presence of Mind should not apply cooldown mods on c… (#17890) fix(core/spell): Presence of Mind should not apply cooldown mods on category spells. Mage T4 set 4 set bonus puts cooldown reduction on Presence of Mind which should not be passed down to category spells, because in case of infinity cooldown on Arcane Power it does not get reset when you lose the Presence of Mind aura and Arcane Power stays forever in cooldown or more specifically for 1 month(infinity cooldown). Closes https://github.com/azerothcore/azerothcore-wotlk/issues/17800 Patch 3.0.9 https://wowpedia.fandom.com/wiki/Patch_3.0.9 Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com> * fix(DB/Creature): Archmage Xylem patrol from mangos-wotlk (#19083) fix(DB/Creature): Archmage Xylem pathing * fix(Core/Spells): Don't send SMSG_CAST_FAILED for interrupted spells … (#19082) fix(Core/Spells): Don't send SMSG_CAST_FAILED for interrupted spells after they were launched or channelling was started (this clears cooldown on client) https: //github.com/TrinityCore/TrinityCore/commit/63bc405faeb7afcf99de6f7531e4ea59065165f4 Co-authored-by: Shauren <shauren.trinity@gmail.com> * chore(DB): import pending files Referenced commit(s): 4b0202a5254ec297612a42bf2f2fa27178d50e8f * fix(DB/Procs): Add proc info for lower ranks of Reckoning talent. (#19071) * Init. * Adjust query. Use the rank system supported by the table rather than add the individual rank spell IDs. * Remove redundant query segment. * chore(DB): import pending files Referenced commit(s): 2cf95ca6cbba43139684b3f5ec18c1cf71166f52 * fix(DB/Hyjal): Update conditions after boss index change (#19086) * Create Hyjal * Delete data/sql/updates/pending_db_world/Hyjal * Add files via upload * chore(DB): import pending files Referenced commit(s): 2319789804e5e11f88ef2d8cb2766fc957bca870 * fix(Core/Quest): Correct XP Display when modified by SPELL_AURA_MOD_XP_QUEST_PCT (#19060) * fix(Core): Correct Quest XP Display when modified by SPELL_AURA_MOD_XP_QUEST_PCT The quest XP displayed on the gossip window was not modified for auras that increase quest XP gain (e.g. spell ID 57353). This commit corrects the quest XP display when accepting/returning quests. * refactor(Entities/Player): Added a `CalculateQuestRewardXP()` function to reduce duplicated code * cleanup(Entities/Creature): Removed now unused variable `playerLevel` * Apply suggestions from code review Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com> --------- Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com> * fix(DB/Creature): Port Force-Commander Gorax patrol from mangos-wotlk (#19089) * chore(DB): import pending files Referenced commit(s): dea3748629e61434cf3e6cc73dd5223f04b1a9b2 * fix(DB/Creature): Mote of Shadow incorrect low value for 2 npcs (#19088) * chore(DB): import pending files Referenced commit(s): a644425758414071046d91f7701f5176955316f1 * fix(Scripts/ICC): Fix Valithria reseting (#19087) * fix(Scripts/Spells): Implement damage scaling based off DoT stack count for Seal of Vengeance and Corruption. (#19073) * Init. * Whoops. * Move comment. Someone should fix this darn CI. * Logic adjustment. * Revert logic adjustment. This reverts commit ee09ee55df47c9a66ecf536be58a4a040f384b72. * Requested changes? * chore(DB): import pending files Referenced commit(s): 8ea13ca778931f3d018472e0be47596c17615917 * fix(DB/Creature): Fix minor issues with Dragonmaw Peons (#19091) Create rev_1718749668931737500.sql * chore(DB): import pending files Referenced commit(s): eaa09ed95e20324a3cc9c9e189ad4502412f30dd * fix(Core/SmartAI): add prevent almost infinite spinning of mutual target to pets (#19090) fix(Core/SmartAI)petspin * fix(DB/Command): fix help typo 'trigered' for .cast commands (#19092) * chore(DB): import pending files Referenced commit(s): 4b8b06b250c669e1811dee8a8269c61a2ce4e9a6 * fix(DB/Loot): Correct oversight with Hyjal trash loot. (#19095) Init. * chore(DB): import pending files Referenced commit(s): 81d4c2e1454c99d54e28ad8d46c0aea31e01ffe8 * fix(Scripts/Hyjal): Fix wave count not showing for Rage Winterchill waves fix(Scripts/Hyjal): Fix wave count not showing for Rage Winterchill waves * fix(DB/Loot): Adjust Ancient Gem Vein loot table. (#19097) Init. https: //github.com/cmangos/tbc-db/commit/2f458511c4e9d02b5a90891c706ce86b0c3b8013 Co-authored-by: AnonXS <19734826+AnonXS@users.noreply.github.com> * chore(DB): import pending files Referenced commit(s): d568544c5c81bd59bd9518638ceaa2c5d3980503 * fix(Core/Spells): Partially revert spell cancel behavior change. (#19101) Init. * fix(DB/Creature): Illidari Fearbringer immunities (#19099) * fix(DB/Creature): Bonechewer Taskmaster taunt immunity (#19098) * fix(DB/Conditions): Spell Protection of Elune only targets players (#19094) * chore(DB): import pending files Referenced commit(s): 81ac2a584fb9941d229dabf05db22370451b52bc * fix(DB/Kalimdor): limit Warchief's Blessing to Horde only (#19025) * init sql * remove 63 requirement from WCB * fix(DB/Creature): Spirit of Zandalar limit to 63 and below, apply to Booty Bay (#19024) init * chore(DB): import pending files Referenced commit(s): 39e4dd1714eccceb74af2d8b99fca31028b2c972 * fix(Scripts/Spell): adjust Thrall's and Herald WCB timings, limit to Orgrimmar and Crossroads (#19026) * update smartAI herald * refactor _scheduler to scheduler * adjust timings of WCB Thrall * limit WCB to Orgrimmar and Crossroads * add roar emote * style, add second loop to delay crossroads cast * limit shout range to area * rename p to player * chore(DB): import pending files Referenced commit(s): 6d86fb3721bfd4c1551d28058c5ea42927d9c6dd * fix(DB/Creature): Correct Doomfire/Spirit speed. (#19105) Init. * chore(DB): import pending files Referenced commit(s): 3f0b140f01b7b1b115d82986109fd87d5a46f163 * fix(Scripts/Midsummer): Resolve Ribbon Pole crash. (#19108) * Init. * Add todo. For you, Nyeriah. :stuck_out_tongue: * fix(Core/Ahune): Chest and Quest (#19106) * Add files via upload * Update boss_ahune.cpp * Update boss_ahune.cpp * Update boss_ahune.cpp * fix(DB/Creature): Finish correcting Doomfire Spirit speed. (#19110) Init. * chore(DB): import pending files Referenced commit(s): a8b09880fdb006f1b6d808bd8d957ba798d32908 * fix(Scripts/Midsummer): use GUID storage rather than Player object (#19109) * Update midsummer.cpp * Update midsummer.cpp * Update midsummer.cpp * fix(DB/Creature): add TRIGGER flag to 'Ribbon Pole Fire Spiral Bunny' (#19115) * chore(DB): import pending files Referenced commit(s): d4c25e589202da38611df29b0691c3354baa65ae * fix(DB/Gossip): Refik missing text for lowlevel tailoring (#19111) * chore(DB): import pending files Referenced commit(s): 9572cbfaca968db700733cc8e54d9b01bee5a463 * fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_CAN_FAIL_IN… (#19116) fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_CAN_FAIL_IN_ANY_STATE - this allows flagging quests so that they are allowed to fail in Player::FailQuest() independant of their current state - update quest 853 accordingly as a first use case * chore(DB): import pending files Referenced commit(s): b3f21d909ae83617c599de1f02a619fd200e3b5c * fix(Scripts/Kalimdor) Thrall Warchief's Blessing, add level and reputation requirement, spike activation (#19121) * activates pike * add sql * chore(DB): import pending files Referenced commit(s): ada343a6b31e4f25328c5fe7b7bb305f682b50d0 * refactor(Scripts/TempestKeep): Spell Scripts use registry macros (#19123) * init sql * instance_the_eye aura:spell_the_eye_countercharge_aura * instance_the_botanica aura:spell_botanica_call_of_the_falcon_aura * instance_the_botanica aura:spell_botanica_shift_form_aura * arcatraz aura:spell_arcatraz_soul_steal_aura * refactor(Scripts/BlackTemple): Spell Scripts use registry macros (#19122) * chore(DB): import pending files Referenced commit(s): f65283c35a99c7b3f13113beff74c31eefc80c9c * fix(DB/Creature): Fix Dragonmaw Wind Rider and Sky Stalker taunt immu… (#19120) fix(DB/Creature): Fix Dragonmaw Wind Rider and Sky Stalker taunt immunity * fix(DB/Spells): Scourgebane Draugh & Infusion should stack with flask… (#19119) fix(DB/Spells): Scourgebane Draugh & Infusion should stack with flasks and elixirs * fix(DB/Creature): Fix Dragonmaw Wind Rider interrupt immunity (#19118) fix(DB/Creature): Fix Dragonmaw Wind Rider immunities * chore(DB): import pending files Referenced commit(s): 842918c08cc91aaf052e7cf8c1002981907e11da * fix(DB/Conditions): Thrall's WCB fixup (#19125) fixup * chore(DB): import pending files Referenced commit(s): dba80c88045b16b4ce81650eac94b918670a99fa * refactor(Scripts/Hodir): spellscripts use registry macros (#19126) * chore(DB): import pending files Referenced commit(s): 9c7cf93cd8e082aa63d9dbe94f115a94616587f6 * refactor(Scripts/Northrend): dungeons Spell Scripts registry macros (#19134) * instance_azjol_nerub spell:spell_azjol_nerub_fixate * instance_azjol_nerub aura:spell_azjol_nerub_web_wrap_aura * boss_hadronox aura:spell_hadronox_summon_periodic_aura * boss_hadronox aura:spell_hadronox_leech_poison_aura * boss_argent_challenge spell:spell_eadric_radiance * boss_argent_challenge spell:spell_toc5_light_rain * boss_argent_challenge aura:spell_reflective_shield_aura * fixup! boss_argent_challenge aura:spell_reflective_shield_aura * instance_drak_tharon_keep aura:spell_dtk_raise_dead_aura * instance_drak_tharon_keep spell:spell_dtk_summon_random_drakkari * boss_trollgore spell:spell_trollgore_consume * boss_trollgore aura:spell_trollgore_corpse_explode_aura * boss_trollgore spell:spell_trollgore_invader_taunt * boss_novos spell:spell_novos_despawn_crystal_handler * boss_novos aura:spell_novos_crystal_handler_death_aura * boss_novos spell:spell_novos_summon_minions * boss_tharon_ja aura:spell_tharon_ja_curse_of_life_aura * boss_tharon_ja aura:spell_tharon_ja_dummy_aura * boss_tharon_ja spell:spell_tharon_ja_clear_gift_of_tharon_ja * boss_dred aura:spell_dred_grievious_bite_aura * boss_dred spell:spell_dred_raptor_call * boss_moorabi aura:spell_moorabi_mojo_frenzy_aura * boss_slad_ran aura:spell_sladran_grip_of_sladran_aura * boss_drakkari_colossus spell:spell_drakkari_colossus_emerge * boss_drakkari_colossus spell:spell_drakkari_colossus_surge * boss_drakkari_colossus spell:spell_drakkari_colossus_face_me * boss_gal_darah spell:spell_galdarah_impaling_charge * boss_gal_darah spell:spell_galdarah_transform * boss_malygos spell:spell_eoe_ph3_surge_of_power * oculus aura:spell_oculus_stop_time_aura * oculus aura:spell_oculus_evasive_maneuvers_aura * oculus spell:spell_oculus_shock_lance * oculus aura:spell_oculus_temporal_rift_aura * oculus spell:spell_oculus_touch_the_nightmare * oculus aura:spell_oculus_dream_funnel_aura * oculus spell:spell_oculus_call_ruby_emerald_amber_drake * oculus aura:spell_oculus_ride_ruby_emerald_amber_drake_que_aura * oculus aura:spell_oculus_evasive_charges_aura * oculus aura:spell_oculus_soar_aura * oculus aura:spell_oculus_rider_aura * oculus aura:spell_oculus_drake_flag_aura * boss_magus_telestra aura:spell_boss_magus_telestra_summon_telestra_clones_aura * boss_magus_telestra spell:spell_boss_magus_telestra_gravity_well * utgarde_keep aura:spell_ticking_time_bomb_aura * boss_keleseth aura:spell_frost_tomb_aura * boss_svala pair:spell_svala_ritual_strike * boss_moragg aura:spell_optic_link_aura * violet_hold aura:spell_destroy_door_seal_aura * forge_of_souls aura:spell_shield_of_bones_aura * boss_devourer_of_souls aura:spell_wailing_souls_periodic_aura * boss_bronjahm spell:spell_bronjahm_magic_bane * boss_bronjahm aura:spell_bronjahm_soulstorm_channel_ooc_aura * boss_bronjahm aura:spell_bronjahm_soulstorm_visual_aura * boss_bronjahm spell:spell_bronjahm_soulstorm_targeting * boss_krickandick aura:spell_krick_explosive_barrage_aura * boss_krickandick aura:spell_exploding_orb_auto_grow_aura * pit_of_saron aura:spell_pos_empowered_blizzard_aura * pit_of_saron spell:spell_pos_slave_trigger_closest * pit_of_saron spell:spell_pos_rimefang_frost_nova * pit_of_saron aura:spell_pos_blight_aura * pit_of_saron aura:spell_pos_glacial_strike_aura * boss_forgemaster_garfrost spell:spell_garfrost_permafrost * halls_of_reflection aura:spell_hor_gunship_cannon_fire_aura * boss_marwyn aura:spell_hor_shared_suffering_aura * fixup! forge_of_souls aura:spell_shield_of_bones_aura * fixup! boss_bronjahm aura:spell_bronjahm_soulstorm_channel_ooc_aura * fixup! boss_bronjahm aura:spell_bronjahm_soulstorm_visual_aura * fixup! pit_of_saron aura:spell_pos_empowered_blizzard_aura * fixup! halls_of_reflection aura:spell_hor_gunship_cannon_fire_aura * fixup! boss_marwyn aura:spell_hor_shared_suffering_aura * chore(DB): import pending files Referenced commit(s): cd9dff503258445958922be5643829aa21a8461e * fix(Scripts/Midsummer): fix handling of unwanted npc and gameobject s… (#19141) fix(Scripts/Midsummer): fix handling of unwanted npc and gameobject spawns - properly spawn bonfire spell focus for city bonfires - properly despawn unwanted creatures and gameobjects which are spawned by linked traps - all midsummer bonfire gameobjects have a linked trap "181290 Midsummer Bonfire Spawn Trap" - the trap is linked to the spell "28784 Summon Midsummer Bonfire Bunnies" which then spawns npc "16592 Midsummer Bonfire", npc "16606 Midsummer Bonfire Despawner" and gameobject "181371 Midsummer Bonfire Spell Focus" i have no idea how this trap is beeing triggered, but it's doing only harm right now * chore(DB): import pending files Referenced commit(s): 3d03cb64ba109fd845ca0e96a921d0385765d937 * fix(Script/ICC): Make Plagueworks Release Valves noninteractable afte… (#19133) fix(Script/ICC): Make Plagueworks Release Valves noninteractable after use * closes https://github.com/azerothcore/azerothcore-wotlk/issues/19072 * refactor(Scripts/Northrend): fixup spell_hadronox_summon_periodic_crypt_fiend_aura (#19142) rename other args fixup https://github.com/azerothcore/azerothcore-wotlk/commit/cd9dff503258445958922be5643829aa21a8461e#commitcomment-143444310 * chore(DB): import pending files Referenced commit(s): 240314efb544521d50040538a03acdc6f0f69f35 * fix(DB/SAI): Torek's Assault not completing for party members (#19143) * chore(DB): import pending files Referenced commit(s): 81225e4e603fbd39f6b1b9311191b3e131f60e97 * fix(DB/Creature): Add parry hasting exception for a few TBC raid bosses. (#19149) * Init. * Whoops. * chore(DB): import pending files Referenced commit(s): 5e423b3bcbe541523f61bd4d019d911431b93823 * fix(Creature): Adjust Ahune Frozen Core level. (#19150) * Init. * Forgot the heroic difficulty entry, not base. * chore(DB): import pending files Referenced commit(s): b2457ef67e4e0a3cde875ef2a1c00b4624cacd48 * fix(CI): fix Error.log check (#19161) * refactor(Scripts/Outland): spell scripts use registry macros (#19132) * zone_terokkar_forest pair:spell_q10930_big_bone_worm * zone_terokkar_forest spell:spell_q10036_torgos * zone_terokkar_forest spell:spell_q10923_evil_draws_near_summon * zone_terokkar_forest aura:spell_q10923_evil_draws_near_periodic_aura * zone_terokkar_forest spell:spell_q10923_evil_draws_near_visual * zone_terokkar_forest spell:spell_q10898_skywing * zone_hellfire_peninsula spell:spell_q10935_the_exorcism_of_colonel_jules * boss_doomlord_kazzak aura:spell_mark_of_kazzak_aura * zone_blades_edge_mountains aura:spell_npc22275_crystal_prison_aura * zone_blades_edge_mountains spell:spell_oscillating_field * zone_shadowmoon_valley spell:spell_q10612_10613_the_fel_and_the_furious * zone_shadowmoon_valley aura:spell_q10563_q10596_to_legion_hold_aura * fixup! zone_hellfire_peninsula spell:spell_q10935_the_exorcism_of_colonel_jules fixup! zone_hellfire_peninsula spell:spell_q10935_the_exorcism_of_colonel_jules * fixup! zone_blades_edge_mountains aura:spell_npc22275_crystal_prison_aura * fixup! zone_shadowmoon_valley spell:spell_q10612_10613_the_fel_and_the_furious * fixup! zone_blades_edge_mountains spell:spell_oscillating_field * zone_terokkar_forest pair:spell_q10929_fumping * chore(DB): import pending files Referenced commit(s): 7a77a3e4f9165e819577b7f32b1260eb4d08ac3d * fix(DB/Conditions): Zaxxis Insignia should drop without any conditions. (#19158) * chore(DB): import pending files Referenced commit(s): ce0b1ad8a9a51fe6c13fe71a42d2ff92d9faffa6 * fix(DB/Loot): Correct chances related to Captain Rumsey's Lager recipe. (#19166) Init. * chore(DB): import pending files Referenced commit(s): b1fc1c34b71df9596fd0e43b4907d59deb422f56 * fix(Core/Spells): Script Drunken Haze & Drunken Skull Crack (#19164) * fix(Core/Spells): Script Drunken Haze & Drunken Skull Crack * bruh * sigh * fix(DB/SAI): Kirin'Var Apprentice not throwing hammer and missing aura (#19163) * fix(DB/Creature): Link Durnholde Lodges formation (#19159) * fix(DB/Formations): Link Durnholde Lodges * ? * ?? * fix(DB/Loot): Add guaranteed drops to Ethereum Prisoner loot tables. (#19156) Init. * fix(DB/SAI): Lashh'an Talonite pets (#19154) * fix(DB/SAI): Lashh'an Talonite pets * creature_text * ) * chore(DB): import pending files Referenced commit(s): cc314303684d26e2f55392e8eba19fe05398da2d * fix(DB/SAI): Tormented Soul & Soulbind spell (#19162) * fix(DB/SAI): Tormented Soul & Soulbind spell * 20480 is just for looks * allowOverride 0 * ... * Set Reactstate Aggressive * chore(DB): import pending files Referenced commit(s): c3fd59325cb1e0762d703e51e7d0a567b2d6b286 --------- Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: sudlud <sudlud@users.noreply.github.com> Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com> Co-authored-by: chaosua <544218+chaosua@users.noreply.github.com> Co-authored-by: silviu20092 <dobrescu.silviu92@gmail.com> Co-authored-by: Jelle Meeus <sogladev@gmail.com> Co-authored-by: Mike Delago <32778141+michaeldelago@users.noreply.github.com> Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com> Co-authored-by: Mykhailo Redko <ovitnez@gmail.com> Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com> Co-authored-by: daobashun <49193927+fangshun2004@users.noreply.github.com> Co-authored-by: qwe900 <qwe900@web.de> Co-authored-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com> Co-authored-by: Anton Popovichenko <anton.popovichenko@mendix.com> Co-authored-by: trickerer <onlysuffering@gmail.com> Co-authored-by: Lukas <53310556+proxical@users.noreply.github.com> Co-authored-by: KJack <kgithub@kellerg.com> Co-authored-by: neifion-00000000 <91289495+neifion-00000000@users.noreply.github.com> Co-authored-by: amed80 <amed80@live.com> Co-authored-by: Walter Pagani <paganiwalter@gmail.com> Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com> Co-authored-by: avarishd <46330494+avarishd@users.noreply.github.com> Co-authored-by: xaenerys0 <andrewtipper17@gmail.com> Co-authored-by: Traesh <9392905+traesh@users.noreply.github.com> Co-authored-by: Shauren <shauren.trinity@gmail.com> Co-authored-by: AnchyDev <35346484+AnchyDev@users.noreply.github.com> Co-authored-by: Keader <keader.android@gmail.com> Co-authored-by: Gustavo <sirikfoll@hotmail.com> Co-authored-by: Lyuboslav Kotsev <liumbiwe@gmail.com> Co-authored-by: 天鹿 <18535853+PkllonG@users.noreply.github.com> Co-authored-by: atrapalis <104009206+atrapalis@users.noreply.github.com> Co-authored-by: AnonXS <19734826+AnonXS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
caused by actions/runner-images#9937
also CI should never attempt a restart as this will always disconnect the CI worker as it seems
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.