Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat. block heal and tank talent tree #49

Closed
wants to merge 1 commit into from
Closed

feat. block heal and tank talent tree #49

wants to merge 1 commit into from

Conversation

Tony931023
Copy link

@Tony931023 Tony931023 commented Jul 20, 2023 •
edited by pangolp
Loading

Changes Proposed:

  • block heal and tank talent tree

Issues Addressed:

SOURCE:

Tests Performed:

How to Test the Changes:

@Tony931023
Update npc_arena1v1.cpp
b12c15d 
block heal and tank talent tree
@pangolp
Copy link

pangolp commented Jul 20, 2023

As I told you on the Spanish channel, I wouldn't do it directly this way. I would look for a way to make it adaptable to as many projects as possible. And that is achieved, through configurations.
That way, people can choose to use or not use this functionality. But we are not limited to just one project. Let's try to cover as much as possible.

@pangolp pangolp changed the title block heal and tank talent tree feat. block heal and tank talent tree Jul 20, 2023
@pangolp pangolp self-requested a review July 21, 2023 09:51
pangolp
pangolp suggested changes Jul 21, 2023
View reviewed changes
Copy link

@pangolp pangolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to make the system a little more homogeneous, and that it adapts to many different types of projects. So the best thing, some options inside the .conf file, so that each project decides if it enables or not, this content.

@Tony931023 Tony931023 marked this pull request as draft July 21, 2023 10:09
@pangolp pangolp marked this pull request as ready for review March 17, 2024 01:37
@pangolp pangolp mentioned this pull request Mar 17, 2024
Merged
@pangolp pangolp closed this in #50 Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pangolp pangolp pangolp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Still not working Forbidden Talents!
2 participants
@Tony931023 @pangolp