Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes: Fix .ab creaturestat crash, add creatureIDsThatAreNotClones #162

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

kjack9
Copy link
Collaborator

@kjack9 kjack9 commented Oct 25, 2023

Changes Proposed:

  • Fixes crashing issue when the summoner of a creature no longer exists and .ab creaturestat is used.
  • Add creatureIDsThatAreNotClones list to statically exclude creature IDs that shouldn't have their current health and mana values copied from the summoner.

Issues Addressed:

SOURCE:

Tests Performed:

  • Builds
  • Works great on Attumen the Huntsman

How to Test the Changes:

  1. .go xyz -11144.177734 -1903.518677 49.890297 532
  2. Clear trash and engage Midnight
  3. DPS Attumen down to 25%
  4. Observe that the new combined creature has the health of Midnight (higher health of the two)
  5. Target the combined creature and do .ab creaturestat
  6. Observe the server not crashing

@Helias Helias merged commit a20143d into azerothcore:master Oct 25, 2023
1 check passed
@Helias
Copy link
Member

Helias commented Oct 25, 2023

nice 🚀

@kjack9 kjack9 deleted the fix-crash-and-wrong-clones branch October 25, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants