Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a specific mixin environment for doing CAPI mgmt clusters #37

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Add a specific mixin environment for doing CAPI mgmt clusters #37

merged 4 commits into from
Sep 27, 2023

Conversation

mkjpryor
Copy link
Collaborator

@mkjpryor mkjpryor commented Jun 9, 2023

No description provided.

@mkjpryor mkjpryor marked this pull request as draft June 9, 2023 11:13
@mkjpryor mkjpryor force-pushed the feature/capi-mgmt-config branch 2 times, most recently from bff2d53 to 5359494 Compare June 9, 2023 14:28
JohnGarbutt
JohnGarbutt previously requested changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a README or docs we can reference from the StackHPC kayobe config? Maybe that is overkill.

@mkjpryor
Copy link
Collaborator Author

Can we add a README or docs we can reference from the StackHPC kayobe config? Maybe that is overkill.

Personally, I would rather we do the opposite, and keep the azimuth-config docs clean for Azimuth deployments.

@mkjpryor mkjpryor force-pushed the feature/capi-mgmt-config branch from 5359494 to f5bd27e Compare September 27, 2023 12:55
@mkjpryor mkjpryor marked this pull request as ready for review September 27, 2023 15:30
@mkjpryor mkjpryor requested a review from scrungus September 27, 2023 15:30
scrungus
scrungus approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@scrungus scrungus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkjpryor mkjpryor merged commit dc1e147 into main Sep 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrungus scrungus scrungus approved these changes

@JohnGarbutt JohnGarbutt JohnGarbutt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkjpryor @JohnGarbutt @scrungus