refactor: lint

aziontech · Oct 21, 2024 · 06e9aff · 06e9aff
1 parent 679e2f7
commit 06e9aff
Show file tree

Hide file tree

Showing 11 changed files with 29 additions and 21 deletions.
diff --git a/pkg/cmd/create/personal_token/expiration_date.go b/pkg/cmd/create/personal_token/expiration_date.go
@@ -26,12 +26,16 @@ func ParseExpirationDate(currentDate time.Time, expirationString string) (time.T
 	}
 
 	// If the string contains a suffix, it is a range format
-	lastChar := expirationString[len(expirationString) - 1]
+	lastChar := expirationString[len(expirationString)-1]
 	if interval, ok := suffixMapping[lastChar]; ok {
 		intervalValue := 0
-		fmt.Sscanf(string(expirationString[0]), "%d", &intervalValue)
+		_, err := fmt.Sscanf(string(expirationString[0]), "%d", &intervalValue)
+		if err != nil {
+			return time.Now(), err
+		}
+
 		expirationDate := currentDate.Add(time.Duration(intervalValue) * interval)
-		return time.Parse(constants.FORMAT_DATE, expirationDate.Format(constants.FORMAT_DATE))	
+		return time.Parse(constants.FORMAT_DATE, expirationDate.Format(constants.FORMAT_DATE))
 	}
 
 	// Try to analyze as full date (yyyy-mm-dd) or (dd/mm/yyyy)

diff --git a/pkg/cmd/delete/domain/domain_test.go b/pkg/cmd/delete/domain/domain_test.go
@@ -100,7 +100,7 @@ func TestDeleteWithAskInput(t *testing.T) {
 			expectedOutput: "",
 			expectError:    true,
 			mockInputs:     mockInvalid,
-			mockError:      fmt.Errorf(msg.ErrorConvertId.Error()),
+			mockError:      msg.ErrorConvertId,
 		},
 		{
 			name:           "error - parse answer",
@@ -112,7 +112,7 @@ func TestDeleteWithAskInput(t *testing.T) {
 			expectedOutput: "",
 			expectError:    true,
 			mockInputs:     mockParseError,
-			mockError:      fmt.Errorf(utils.ErrorParseResponse.Error()),
+			mockError:      utils.ErrorParseResponse,
 		},
 	}
 

diff --git a/pkg/cmd/delete/edge_application/cascade.go b/pkg/cmd/delete/edge_application/cascade.go
@@ -33,7 +33,10 @@ func CascadeDelete(ctx context.Context, del *DeleteCmd) error {
 	}
 
 	if azionJson.Function.ID == 0 {
-		fmt.Fprintf(del.f.IOStreams.Out, msg.MissingFunction)
+		_, err := fmt.Fprintf(del.f.IOStreams.Out, "%s", msg.MissingFunction)
+		if err != nil {
+			return err
+		}
 	} else {
 		err = clientfunc.Delete(ctx, azionJson.Function.ID)
 		if err != nil {

diff --git a/pkg/cmd/delete/edge_application/edge_application_test.go b/pkg/cmd/delete/edge_application/edge_application_test.go
@@ -104,7 +104,7 @@ func TestDeleteWithAskInput(t *testing.T) {
 			expectedOutput: "",
 			expectError:    true,
 			mockInputs:     mockInvalid,
-			mockError:      fmt.Errorf(msg.ErrorConvertId.Error()),
+			mockError:      msg.ErrorConvertId,
 		},
 		{
 			name:           "error - parse answer",

diff --git a/pkg/cmd/delete/edge_function/edge_function_test.go b/pkg/cmd/delete/edge_function/edge_function_test.go
@@ -100,7 +100,7 @@ func TestDeleteWithAskInput(t *testing.T) {
 			expectedOutput: "",
 			expectError:    true,
 			mockInputs:     mockInvalidFunctionID,
-			mockError:      fmt.Errorf(msg.ErrorConvertIdFunction.Error()),
+			mockError:      msg.ErrorConvertIdFunction,
 		},
 		{
 			name:           "error - parse answer",
@@ -112,7 +112,7 @@ func TestDeleteWithAskInput(t *testing.T) {
 			expectedOutput: "",
 			expectError:    true,
 			mockInputs:     mockParseErrorFunctionID,
-			mockError:      fmt.Errorf(utils.ErrorParseResponse.Error()),
+			mockError:      utils.ErrorParseResponse,
 		},
 	}
 

diff --git a/pkg/cmd/delete/personal_token/personal_token_test.go b/pkg/cmd/delete/personal_token/personal_token_test.go
@@ -69,7 +69,7 @@ func TestDeleteCmd(t *testing.T) {
 			expectedOutput: "",
 			expectError:    true,
 			mockInputs:     mockInvalid,
-			mockError:      fmt.Errorf(utils.ErrorParseResponse.Error()),
+			mockError:      utils.ErrorParseResponse,
 		},
 	}
 

diff --git a/pkg/cmd/deploy/upload.go b/pkg/cmd/deploy/upload.go
@@ -38,8 +38,8 @@ type CustomEndpointResolver struct {
 }
 
 // ResolveEndpoint is the method that defines the custom endpoint
-func (e *CustomEndpointResolver) ResolveEndpoint(service, region string) (aws.Endpoint, error) {
-	return aws.Endpoint{
+func (e *CustomEndpointResolver) ResolveEndpoint(service, region string) (aws.Endpoint, error) { // nolint
+	return aws.Endpoint{ //nolint
 		URL:           e.URL,
 		SigningRegion: e.SigningRegion,
 	}, nil
@@ -234,7 +234,7 @@ func uploadFiles(f *cmdutil.Factory, msgs *[]string, pathStatic string, settings
 	cfg, err := config.LoadDefaultConfig(context.TODO(),
 		config.WithRegion(region),
 		config.WithCredentialsProvider(credentials.NewStaticCredentialsProvider(settings.S3AccessKey, settings.S3SecreKey, "")),
-		config.WithEndpointResolver(endpointResolver),
+		config.WithEndpointResolver(endpointResolver), // nolint
 	)
 	if err != nil {
 		return errors.New("unable to load SDK config, " + err.Error())

diff --git a/pkg/cmd/unlink/unlink.go b/pkg/cmd/unlink/unlink.go
@@ -61,7 +61,7 @@ func (cmd *UnlinkCmd) run() error {
 		if err != nil {
 			return err
 		}
-		fmt.Fprintf(cmd.F.IOStreams.Out, msg.UnlinkSuccess)
+		fmt.Fprintf(cmd.F.IOStreams.Out, "%s", msg.UnlinkSuccess)
 	}
 	return nil
 }
diff --git a/pkg/cmd/whoami/whoami.go b/pkg/cmd/whoami/whoami.go
@@ -1,8 +1,6 @@
 package whoami
 
 import (
-	"fmt"
-
 	"github.com/MakeNowJust/heredoc"
 	msg "github.com/aziontech/azion-cli/messages/whoami"
 	"github.com/aziontech/azion-cli/pkg/cmdutil"
@@ -60,7 +58,7 @@ func (cmd *WhoamiCmd) run() error {
 	}
 
 	whoamiOut := output.GeneralOutput{
-		Msg:   fmt.Sprintf(settings.Email + "\n"),
+		Msg:   settings.Email + "\n",
 		Out:   cmd.Io.Out,
 		Flags: cmd.F.Flags,
 	}

diff --git a/pkg/node/node.go b/pkg/node/node.go
@@ -47,7 +47,10 @@ func checkNode(str string) error {
 		majorVersion := versionParts[0]
 
 		var major int
-		fmt.Sscanf(majorVersion, "%d", &major)
+		_, err := fmt.Sscanf(majorVersion, "%d", &major)
+		if err != nil {
+			return err
+		}
 
 		if major < 18 {
 			return errors.New(NODE_OLDER_VERSION)

diff --git a/pkg/node/node_test.go b/pkg/node/node_test.go
@@ -28,13 +28,13 @@ func Test_checkNode(t *testing.T) {
 			name:    "case 03",
 			args:    "v",
 			wantErr: true,
-			err:     NODE_OLDER_VERSION,
+			err:     "EOF",
 		},
 		{
 			name:    "case 04",
 			args:    "",
 			wantErr: true,
-			err:     NODE_OLDER_VERSION,
+			err:     "EOF",
 		},
 		{
 			name:    "case 05",
@@ -55,7 +55,7 @@ func Test_checkNode(t *testing.T) {
 			name:    "case 08",
 			args:    "vX.Y.Z",
 			wantErr: true,
-			err:     NODE_OLDER_VERSION,
+			err:     "expected integer",
 		},
 		{
 			name:    "case 09",