Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add delete/rule-engine command #509

Merged
merged 2 commits into from
Sep 26, 2023
Merged

feat: add delete/rule-engine command #509

merged 2 commits into from
Sep 26, 2023

Conversation

PatrickMenoti
Copy link
Collaborator

WHAT

  • Add delete command to rule-engine;
  • Add team-platform-data as codeowners of azion-cli;

@PatrickMenoti PatrickMenoti requested a review from a team September 22, 2023 18:23
@PatrickMenoti PatrickMenoti self-assigned this Sep 22, 2023
LucasGeneroso
LucasGeneroso reviewed Sep 22, 2023
View reviewed changes
Copy link

@LucasGeneroso LucasGeneroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it needs to be like this for it to work:

CODEOWNERS Show resolved Hide resolved
maxwelbm
maxwelbm previously approved these changes Sep 25, 2023
View reviewed changes
@PatrickMenoti PatrickMenoti merged commit 992f2e1 into dev Sep 26, 2023
2 checks passed
@PatrickMenoti PatrickMenoti deleted the delete-cmd-rule branch September 26, 2023 17:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LucasGeneroso LucasGeneroso LucasGeneroso left review comments

@gabriel-azion gabriel-azion gabriel-azion approved these changes

@maxwelbm maxwelbm maxwelbm approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PatrickMenoti @LucasGeneroso @maxwelbm @gabriel-azion