Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add list/rule-engine command #511

Merged
merged 7 commits into from
Sep 26, 2023
Merged

feat: add list/rule-engine command #511

merged 7 commits into from
Sep 26, 2023

Conversation

PatrickMenoti
Copy link
Collaborator

WHAT

  • Add list rule-engine command;
  • Unit tests;

@PatrickMenoti PatrickMenoti requested a review from a team September 25, 2023 15:18
@PatrickMenoti PatrickMenoti self-assigned this Sep 25, 2023
maxwelbm
maxwelbm previously approved these changes Sep 25, 2023
maxwelbm
maxwelbm previously approved these changes Sep 26, 2023
Co-authored-by: Gabriel França <119522814+gabriel-azion@users.noreply.github.com>
ErrorGetRulesEngines = errors.New("Failed to list your rules in Rules Engine: %s. Check your settings and try again. If the error persists, contact Azion support.")
ErrorMandatoryListFlags = errors.New("One or more required flags are missing. You must provide the --application-id and --phase flags. Run the command 'azion rules_engine list --help' to display more information and try again.")
ErrorMandatoryFlags = errors.New("One or more required flags are missing. You must provide the --application-id, --rules-id, and --phase flags. Run the command 'azion rules_engine <subcommand> --help' to display more information and try again.")
ErrorMandatoryFlags = errors.New("One or more required flags are missing. You must provide the --application-id, --rules-id, and --phase flags. Run the command 'azioncli rules_engine <subcommand> --help' to display more information and try again.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ErrorMandatoryFlags = errors.New("One or more required flags are missing. You must provide the --application-id, --rules-id, and --phase flags. Run the command 'azioncli rules_engine <subcommand> --help' to display more information and try again.")
ErrorMandatoryFlags = errors.New("One or more required flags are missing. You must provide the --application-id, --rules-id, and --phase flags. Run the command 'azion <command> rules_engine --help' to display more information and try again.")

@PatrickMenoti PatrickMenoti requested a review from a team as a code owner September 26, 2023 17:24
gabriel-azion
gabriel-azion previously approved these changes Sep 26, 2023
@PatrickMenoti PatrickMenoti merged commit 64a5419 into dev Sep 26, 2023
2 checks passed
@PatrickMenoti PatrickMenoti deleted the list-rules branch September 26, 2023 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants