-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add list/rule-engine command #511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwelbm
previously approved these changes
Sep 25, 2023
maxwelbm
previously approved these changes
Sep 26, 2023
Co-authored-by: Gabriel França <119522814+gabriel-azion@users.noreply.github.com>
messages/rules_engine/errors.go
Outdated
ErrorGetRulesEngines = errors.New("Failed to list your rules in Rules Engine: %s. Check your settings and try again. If the error persists, contact Azion support.") | ||
ErrorMandatoryListFlags = errors.New("One or more required flags are missing. You must provide the --application-id and --phase flags. Run the command 'azion rules_engine list --help' to display more information and try again.") | ||
ErrorMandatoryFlags = errors.New("One or more required flags are missing. You must provide the --application-id, --rules-id, and --phase flags. Run the command 'azion rules_engine <subcommand> --help' to display more information and try again.") | ||
ErrorMandatoryFlags = errors.New("One or more required flags are missing. You must provide the --application-id, --rules-id, and --phase flags. Run the command 'azioncli rules_engine <subcommand> --help' to display more information and try again.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
ErrorMandatoryFlags = errors.New("One or more required flags are missing. You must provide the --application-id, --rules-id, and --phase flags. Run the command 'azioncli rules_engine <subcommand> --help' to display more information and try again.") | |
ErrorMandatoryFlags = errors.New("One or more required flags are missing. You must provide the --application-id, --rules-id, and --phase flags. Run the command 'azion <command> rules_engine --help' to display more information and try again.") |
gabriel-azion
previously approved these changes
Sep 26, 2023
gabriel-azion
approved these changes
Sep 26, 2023
maxwelbm
approved these changes
Sep 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT