Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate support for PHP 8.3 #430

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Indicate support for PHP 8.3 #430

merged 2 commits into from
Nov 22, 2023

Conversation

gsteel
Copy link
Contributor

@gsteel gsteel commented Nov 21, 2023

No description provided.

@coveralls
Copy link

coveralls commented Nov 21, 2023

Pull Request Test Coverage Report for Build 6954295005

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.005%

Totals Coverage Status
Change from base Build 6953663924: 0.0%
Covered Lines: 4179
Relevant Lines: 4221

💛 - Coveralls

@gsteel
Copy link
Contributor Author

gsteel commented Nov 21, 2023

Is it worth going through test failures on MacOS with…

if (is_darwin()) {
    static::markTestSkipped('MacOS has floating point issues (And issues with ext-intl)');
}

It would make running the mutation tests easier locally… ?

@veewee
Copy link
Collaborator

veewee commented Nov 21, 2023

Thanks for the PR! Much appreciated.

About:

if (is_darwin()) {
    static::markTestSkipped('MacOS has floating point issues (And issues with ext-intl)');
}

I've fixed those together with the infection issues in PR #427 but it isn't merged yet.
Looking at the errors in github actions, I think they are all covered.
So it should be fine after that one is merged.

@gsteel
Copy link
Contributor Author

gsteel commented Nov 21, 2023

👍 Thanks @veewee

@veewee veewee added this to the 2.8.0 milestone Nov 22, 2023
@veewee veewee added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: In Progress This issue is being worked on, and has someone assigned. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity labels Nov 22, 2023
@veewee
Copy link
Collaborator

veewee commented Nov 22, 2023

@gsteel That PR that was blocking the tests has been merged. Can you rebase from the next branch?

@veewee veewee added Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Nov 22, 2023
@veewee veewee merged commit 4955aa9 into azjezz:next Nov 22, 2023
14 checks passed
@veewee
Copy link
Collaborator

veewee commented Nov 22, 2023

Thanks again!

@gsteel gsteel deleted the PHP-8.3 branch November 22, 2023 08:06
renovate bot referenced this pull request in ben-challis/sql-migrations Nov 23, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [azjezz/psl](https://togithub.com/azjezz/psl) | `2.7.0` -> `2.8.0` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/azjezz%2fpsl/2.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/azjezz%2fpsl/2.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/azjezz%2fpsl/2.7.0/2.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/azjezz%2fpsl/2.7.0/2.8.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>azjezz/psl (azjezz/psl)</summary>

### [`v2.8.0`](https://togithub.com/azjezz/psl/releases/tag/2.8.0):
Lenalee - 2.8.0

[Compare Source](https://togithub.com/azjezz/psl/compare/2.7.0...2.8.0)

#### What's Changed

- chore(ga): bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/azjezz/psl/pull/420](https://togithub.com/azjezz/psl/pull/420)
- Fix mutations + math float tests by
[@&#8203;veewee](https://togithub.com/veewee) in
[https://github.com/azjezz/psl/pull/427](https://togithub.com/azjezz/psl/pull/427)
- Introduce a comparison component by
[@&#8203;veewee](https://togithub.com/veewee) in
[https://github.com/azjezz/psl/pull/428](https://togithub.com/azjezz/psl/pull/428)
- Indicate support for PHP 8.3 by
[@&#8203;gsteel](https://togithub.com/gsteel) in
[https://github.com/azjezz/psl/pull/430](https://togithub.com/azjezz/psl/pull/430)

#### New Contributors

- [@&#8203;gsteel](https://togithub.com/gsteel) made their first
contribution in
[https://github.com/azjezz/psl/pull/430](https://togithub.com/azjezz/psl/pull/430)

**Full Changelog**: azjezz/psl@2.7.0...2.8.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ben-challis/sql-migrations).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants