Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type): Positive int has a broken exception path #459

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix(type): Positive int has a broken exception path #459

merged 1 commit into from
Apr 4, 2024

Conversation

veewee
Copy link
Collaborator

@veewee veewee commented Apr 4, 2024

Fixes #411

The check is obsolete.
If the trimmed string does not result in a positive int, an exception can be thrown at that moment.

@veewee veewee added Priority: Medium This issue may be useful, and needs some attention. Status: Review Needed The issue has a PR attached to it which needs to be reviewed. Type: Enhancement Most issues will probably ask for additions or changes. labels Apr 4, 2024
@azjezz azjezz merged commit f114031 into azjezz:next Apr 4, 2024
13 checks passed
@azjezz azjezz added this to the 3.0.0 milestone Apr 4, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8553786519

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.907%
Totals Coverage Status
Change from base Build 8524527937: 0.0%
Covered Lines: 4342
Relevant Lines: 4390
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees
No one assigned
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Review Needed The issue has a PR attached to it which needs to be reviewed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

CoercionException::withValue() called but not throwed. Is this dead code?
3 participants
@veewee @coveralls @azjezz