Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change duration to load the correct class in loader #492

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

phpjob
Copy link
Contributor

@phpjob phpjob commented Sep 13, 2024

Loader was fixed as mentioned in #489.

Additional to that i test to load the preload.php, and don't get any other issues.

image

To check if i got before errors, i run the command without the changes.

➜  psl git:(next) php src/preload.php
PHP Warning:  require_once(/dev/psl/src/Psl/DateTime/Interval.php): Failed to open stream: No such file or directory in /dev/psl/src/Psl/Internal/Loader.php on line 943

Warning: require_once(/dev/psl/src/Psl/DateTime/Interval.php): Failed to open stream: No such file or directory in /dev/psl/src/Psl/Internal/Loader.php on line 943
PHP Fatal error:  Uncaught Error: Failed opening required '/dev/psl/src/Psl/DateTime/Interval.php' (include_path='.:/opt/homebrew/Cellar/php/8.3.11/share/php/pear') in /dev/psl/src/Psl/Internal/Loader.php:943
Stack trace:
#0 /dev/psl/src/Psl/Internal/Loader.php(954): Psl\Internal\Loader::load('Psl/DateTime/In...')
#1 [internal function]: Psl\Internal\Loader::Psl\Internal\{closure}('Psl\\DateTime\\Du...')
#2 /dev/psl/src/Psl/Internal/Loader.php(1011): class_exists('Psl\\DateTime\\Du...')
#3 /dev/psl/src/Psl/Internal/Loader.php(936): Psl\Internal\Loader::loadClasses()
#4 /dev/psl/src/Psl/Internal/Loader.php(960): Psl\Internal\Loader::Psl\Internal\{closure}()
#5 /dev/psl/src/Psl/Internal/Loader.php(932): Psl\Internal\Loader::autoload(Object(Closure))
#6 /dev/psl/src/preload.php(9): Psl\Internal\Loader::preload()
#7 {main}
  thrown in /dev/psl/src/Psl/Internal/Loader.php on line 943

Fatal error: Uncaught Error: Failed opening required '/dev/psl/src/Psl/DateTime/Interval.php' (include_path='.:/opt/homebrew/Cellar/php/8.3.11/share/php/pear') in /dev/psl/src/Psl/Internal/Loader.php:943
Stack trace:
#0 /dev/psl/src/Psl/Internal/Loader.php(954): Psl\Internal\Loader::load('Psl/DateTime/In...')
#1 [internal function]: Psl\Internal\Loader::Psl\Internal\{closure}('Psl\\DateTime\\Du...')
#2 /dev/psl/src/Psl/Internal/Loader.php(1011): class_exists('Psl\\DateTime\\Du...')
#3 /dev/psl/src/Psl/Internal/Loader.php(936): Psl\Internal\Loader::loadClasses()
#4 /dev/psl/src/Psl/Internal/Loader.php(960): Psl\Internal\Loader::Psl\Internal\{closure}()
#5 /dev/psl/src/Psl/Internal/Loader.php(932): Psl\Internal\Loader::autoload(Object(Closure))
#6 /dev/psl/src/preload.php(9): Psl\Internal\Loader::preload()
#7 {main}
  thrown in /dev/psl/src/Psl/Internal/Loader.php on line 943

@phpjob
Copy link
Contributor Author

phpjob commented Sep 13, 2024

@veewee fixed.

@veewee veewee merged commit 79a861e into azjezz:next Sep 13, 2024
13 checks passed
@veewee
Copy link
Collaborator

veewee commented Sep 13, 2024

Thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10847126714

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.654%

Totals Coverage Status
Change from base Build 10824565385: 0.0%
Covered Lines: 5350
Relevant Lines: 5423

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants