Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python upper limit #59

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Remove python upper limit #59

merged 1 commit into from
Jul 30, 2023

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Jul 18, 2023

An upper limit for python blocks any attempt to install and test this package for new python versions like 3.12. Even if it doesn't technically work with those yet.

The recommendation for the python pin is usually to only use a lower bound.

@azogue
Copy link
Owner

azogue commented Jul 30, 2023

Hi @cdce8p, thanks for contributing!

The recommendation for the python pin is usually to only use a lower bound.

You're totally right 👌

That is a bad habit of mine 😓, derived from the use of poetry in much more complex projects in terms of dependencies, where there is no other choice but to narrow the python version to achieve a dependency solution; but that's not the case for this library 🤣

@azogue azogue merged commit 863f916 into azogue:master Jul 30, 2023
1 check passed
@cdce8p cdce8p deleted the remove-python-limit branch July 30, 2023 09:53
@cdce8p
Copy link
Contributor Author

cdce8p commented Jul 30, 2023

Thanks for the review! Would you mind releasing a new version. Would be awesome to be able to start testing it with Python 3.12 for Home Assistant. After all the first release candidate is scheduled for tomorrow.

@azogue
Copy link
Owner

azogue commented Jul 30, 2023

Thanks for the review! Would you mind releasing a new version. Would be awesome to be able to start using it with Python 3.12. After all the first release candidate is scheduled for tomorrow.

I'm on it right now 🍻

@azogue azogue mentioned this pull request Jul 30, 2023
@azogue
Copy link
Owner

azogue commented Jul 30, 2023

It's done: https://github.com/azogue/aiopvpc/releases/tag/v4.2.2

Sorry I didn't see this PR before 🙈

@cdce8p
Copy link
Contributor Author

cdce8p commented Jul 30, 2023

Thanks! No worries. It's still early for 3.12.

@cdce8p cdce8p mentioned this pull request Jul 30, 2023
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants