Skip to content

Commit

Permalink
Update Rooms SDK for PSTN GA (Azure#29019)
Browse files Browse the repository at this point in the history
### Packages impacted by this PR
communication-rooms ACS Rooms SDK 

### Issues associated with this PR


### Describe the problem that is addressed by this PR
Updating version following new Rooms version (2024-04-15)


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
  • Loading branch information
allchiang-msft authored Apr 3, 2024
1 parent 40a6141 commit bd6bcfb
Show file tree
Hide file tree
Showing 12 changed files with 207 additions and 202 deletions.
4 changes: 4 additions & 0 deletions sdk/communication/communication-rooms/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Release History

## 1.1.0 (2024-04-15)

- General Availability version of PSTN dial-out capability feature

## 1.1.0-beta.1 (2023-09-21)

### Features Added
Expand Down
4 changes: 2 additions & 2 deletions sdk/communication/communication-rooms/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ If `validFrom` is not provided, it is defaulted to the current datetime. If `val

When defining `participants`, if `role` is not specified, then it will be `attendee` by default.

Starting in 1.1.0-beta.1 release, `PstnDialOutEnabled` property is added to enable or disable PSTN Dial-Out feature in a room. The `PstnDialOutEnabled` is an optional property. If `PstnDialOutEnabled` is not provided, then the default for `PstnDialOutEnabled` is false.
Starting in 1.1.0 release, `PstnDialOutEnabled` property is added to enable or disable PSTN Dial-Out feature in a room. The `PstnDialOutEnabled` is an optional property. If `PstnDialOutEnabled` is not provided, then the default for `PstnDialOutEnabled` is false.

```js
// create users with CommunicationIdentityClient
Expand Down Expand Up @@ -122,7 +122,7 @@ const room = await roomsClient.createRoom(createRoomOptions);

To update the `validFrom` and `validUntil` settings of a room use the `updateRoom` method.

Starting in 1.1.0-beta.1 release, `PstnDialOutEnabled` property is added to enable or disable PSTN Dial-Out feature in a room.
Starting in 1.1.0 release, `PstnDialOutEnabled` property is added to enable or disable PSTN Dial-Out feature in a room.

```js
validForDays = 60;
Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/communication-rooms/assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "js",
"TagPrefix": "js/communication/communication-rooms",
"Tag": "js/communication/communication-rooms_51deddbace"
"Tag": "js/communication/communication-rooms_45d70496ab"
}
4 changes: 2 additions & 2 deletions sdk/communication/communication-rooms/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
"sdk-type": "client",
"author": "Microsoft Corporation",
"description": "Azure client library for Azure Communication Rooms services",
"version": "1.1.0-beta.1",
"version": "1.1.0",
"engines": {
"node": ">=18.0.0"
},
"dependencies": {
"@azure/communication-common": "^2.2.0",
"@azure/communication-common": "^2.3.1",
"@azure/core-auth": "^1.3.2",
"@azure/core-client": "^1.6.0",
"@azure/core-rest-pipeline": "^1.3.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export async function main() {
* @param participants - The Participants being printed to console.
*/
async function printParticipants(
participants: PagedAsyncIterableIterator<Partial<RoomParticipant>>
participants: PagedAsyncIterableIterator<Partial<RoomParticipant>>,
): Promise<void> {
var count = 0;
for await (const participant of participants) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export async function main() {
var validForDays = 10;
var validUntil = addDays(validFrom, validForDays);
var pstnDialOutEnabled = true;

// options payload to create a room
const createRoomOptions: CreateRoomOptions = {
validFrom: validFrom,
Expand Down
Loading

0 comments on commit bd6bcfb

Please sign in to comment.