Skip to content

Commit

Permalink
Add 7.4-preview.1 support, re-record tests (Azure#32220)
Browse files Browse the repository at this point in the history
Resolves Azure#31982
  • Loading branch information
heaths authored Nov 2, 2022
1 parent fea9a34 commit 567a36d
Show file tree
Hide file tree
Showing 378 changed files with 39,435 additions and 40,657 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

### Other Changes

- The default service version is now "7.4-preview.1".

## 4.2.0 (2022-09-20)

### Breaking Changes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

### Other Changes

- The default service version is now "7.4-preview.1".

## 4.4.0 (2022-09-20)

### Breaking Changes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public CertificateClient(System.Uri vaultUri, Azure.Core.TokenCredential credent
}
public partial class CertificateClientOptions : Azure.Core.ClientOptions
{
public CertificateClientOptions(Azure.Security.KeyVault.Certificates.CertificateClientOptions.ServiceVersion version = Azure.Security.KeyVault.Certificates.CertificateClientOptions.ServiceVersion.V7_3) { }
public CertificateClientOptions(Azure.Security.KeyVault.Certificates.CertificateClientOptions.ServiceVersion version = Azure.Security.KeyVault.Certificates.CertificateClientOptions.ServiceVersion.V7_4_Preview_1) { }
public bool DisableChallengeResourceVerification { get { throw null; } set { } }
public Azure.Security.KeyVault.Certificates.CertificateClientOptions.ServiceVersion Version { get { throw null; } }
public enum ServiceVersion
Expand All @@ -82,6 +82,7 @@ public enum ServiceVersion
V7_1 = 1,
V7_2 = 2,
V7_3 = 3,
V7_4_Preview_1 = 4,
}
}
public partial class CertificateContact
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class CertificateClientOptions : ClientOptions
/// For more information, see
/// <see href="https://docs.microsoft.com/rest/api/keyvault/key-vault-versions">Key Vault versions</see>.
/// </summary>
internal const ServiceVersion LatestVersion = ServiceVersion.V7_3;
internal const ServiceVersion LatestVersion = ServiceVersion.V7_4_Preview_1;

/// <summary>
/// The versions of Azure Key Vault supported by this client
Expand Down Expand Up @@ -44,6 +44,11 @@ public enum ServiceVersion
/// The Key Vault API version 7.3.
/// </summary>
V7_3 = 3,

/// <summary>
/// The Key Vault API version 7.4-preview.1.
/// </summary>
V7_4_Preview_1 = 4,
#pragma warning restore CA1707 // Identifiers should not contain underscores
}

Expand Down Expand Up @@ -82,6 +87,7 @@ internal string GetVersionString()
ServiceVersion.V7_1 => "7.1",
ServiceVersion.V7_2 => "7.2",
ServiceVersion.V7_3 => "7.3",
ServiceVersion.V7_4_Preview_1 => "7.4-preview.1",
_ => throw new ArgumentException(Version.ToString()),
};
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,7 @@ public async Task VerifyUpdateCertificatePolicy()
Assert.AreEqual(certificatePolicy.KeySize, updatePolicy.KeySize);
}

[RecordedTest]
[TestCase("application/x-pkcs12")]
[TestCase("application/x-pem-file")]
public async Task DownloadLatestCertificate(string contentType)
Expand Down Expand Up @@ -815,6 +816,7 @@ public async Task DownloadLatestCertificate(string contentType)
CollectionAssert.AreEqual(plaintext, decrypted);
}

[RecordedTest]
[TestCase("application/x-pkcs12")]
[TestCase("application/x-pem-file")]
public async Task DownloadVersionedCertificate(string contentType)
Expand Down Expand Up @@ -872,6 +874,7 @@ public async Task DownloadVersionedCertificate(string contentType)
CollectionAssert.AreEqual(plaintext, decrypted);
}

[RecordedTest]
[TestCase("application/x-pkcs12")]
[TestCase("application/x-pem-file")]
public async Task DownloadNonExportableCertificate(string contentType)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@
namespace Azure.Security.KeyVault.Certificates.Tests
{
[ClientTestFixture(
CertificateClientOptions.ServiceVersion.V7_0,
CertificateClientOptions.ServiceVersion.V7_1,
CertificateClientOptions.ServiceVersion.V7_4_Preview_1,
CertificateClientOptions.ServiceVersion.V7_3,
CertificateClientOptions.ServiceVersion.V7_2,
CertificateClientOptions.ServiceVersion.V7_3)]
CertificateClientOptions.ServiceVersion.V7_1,
CertificateClientOptions.ServiceVersion.V7_0)]
public abstract class CertificatesTestBase : RecordedTestBase<KeyVaultTestEnvironment>
{
protected TimeSpan PollingInterval => Recording.Mode == RecordedTestMode.Playback
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 567a36d

Please sign in to comment.