Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pfcwd] Add single asic unit tests for show commands #1085

Merged
merged 5 commits into from
Sep 1, 2020

Conversation

neethajohn
Copy link
Contributor

@neethajohn neethajohn commented Aug 31, 2020

- What I did
Added single asic unit tests for pfcwd show commands

- How to verify it

platform linux2 -- Python 2.7.16, pytest-3.10.1, py-1.7.0, pluggy-0.8.0 -- /usr/bin/python2
cachedir: .pytest_cache
rootdir: /sonic/src/sonic-utilities/tests, inifile: pytest.ini
plugins: cov-2.6.0
collected 8 items                                                                                                                                                                                                                       

tests/pfcwd_test.py::TestPfcwd::test_pfcwd_show_config PASSED                                                                                                                                                                     [ 12%]
tests/pfcwd_test.py::TestPfcwd::test_pfcwd_show_config_single_port PASSED                                                                                                                                                         [ 25%]
tests/pfcwd_test.py::TestPfcwd::test_pfcwd_show_config_multi_port PASSED                                                                                                                                                          [ 37%]
tests/pfcwd_test.py::TestPfcwd::test_pfcwd_show_config_invalid_port PASSED                                                                                                                                                        [ 50%]
tests/pfcwd_test.py::TestPfcwd::test_pfcwd_show_stats PASSED                                                                                                                                                                      [ 62%]
tests/pfcwd_test.py::TestPfcwd::test_pfcwd_show_stats_single_queue PASSED                                                                                                                                                         [ 75%]
tests/pfcwd_test.py::TestPfcwd::test_pfcwd_show_stats_multi_queue PASSED                                                                                                                                                          [ 87%]
tests/pfcwd_test.py::TestPfcwd::test_pfcwd_show_stats_invalid_queue PASSED                                                                                                                                                        [100%]

Config commands pending on the multi asic db mock

Signed-off-by: Neetha John <nejo@microsoft.com>
Signed-off-by: Neetha John <nejo@microsoft.com>
Signed-off-by: Neetha John <nejo@microsoft.com>
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment.

Very nice resuse of code, BTW. Very clean! 👍

tests/pfcwd_test.py Outdated Show resolved Hide resolved
@smaheshm
Copy link
Contributor

Looks good! Waiting for unit test result.

@smaheshm
Copy link
Contributor

retest this please

Signed-off-by: Neetha John <nejo@microsoft.com>
@jleveque jleveque self-requested a review September 1, 2020 00:04
Signed-off-by: Neetha John <nejo@microsoft.com>
@neethajohn neethajohn merged commit 8d6d871 into sonic-net:master Sep 1, 2020
@neethajohn neethajohn deleted the pfcwd_test branch September 1, 2020 16:05
@abdosi
Copy link
Contributor

abdosi commented Sep 3, 2020

@neethajohn Please create PR for 201911

@smaheshm
Copy link
Contributor

smaheshm commented Sep 8, 2020

@neethajohn @abdosi Will create one PR for both #1080 and #1085

@smaheshm
Copy link
Contributor

smaheshm commented Sep 8, 2020

@neethajohn Please create PR for 201911

#1102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants