Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI][PFCWD][Multi-ASIC] Added multi ASIC support to 'pfcwd' CLI #1102

Merged
merged 5 commits into from
Sep 19, 2020

Conversation

smaheshm
Copy link
Contributor

@smaheshm smaheshm commented Sep 8, 2020

- What I did

Merged following from master into 201911:

#1085 [pfcwd] Add single asic unit tests for show commands
#1080 [CLI][PFCWD][Multi-ASIC] Added multi ASIC support to 'pfcwd' CLI

- How I did it
Manual merge

- How to verify it
Unit tests

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

[CLI][PFCWD][Multi-ASIC] Added multi ASIC support to 'pfcwd' CLI
@lgtm-com
Copy link

lgtm-com bot commented Sep 8, 2020

This pull request introduces 4 alerts when merging 8359abf into 1a949ca - view on LGTM.com

new alerts:

  • 3 for Wrong number of arguments in a call
  • 1 for Unused import

@neethajohn
Copy link
Contributor

Can you fix the LGTM alerts?

@smaheshm
Copy link
Contributor Author

smaheshm commented Sep 8, 2020

looking into import issues.

@lgtm-com
Copy link

lgtm-com bot commented Sep 8, 2020

This pull request introduces 1 alert when merging d199adf into 1a949ca - view on LGTM.com

new alerts:

  • 1 for Syntax error

@smaheshm
Copy link
Contributor Author

smaheshm commented Sep 8, 2020

retest this please

1 similar comment
@smaheshm
Copy link
Contributor Author

retest this please

@smaheshm
Copy link
Contributor Author

retest this please

@abdosi abdosi merged commit 3be8f14 into sonic-net:201911 Sep 19, 2020
@smaheshm smaheshm deleted the 201911-pfcwd-merge branch February 26, 2021 22:33
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
Revert "Revert " [201911]show interface counters for multi ASIC devices
(sonic-net#1104)""
 Revert "Revert "Pfcstat (sonic-net#1097)""
  [show] Fix 'show int neighbor expected' (sonic-net#1106)
   Update argument for docker exec it->i (sonic-net#1118)
     Update to make config load/reload backward compatible. (sonic-net#1115)
     Handling deletion of Port Channel before deletion of its members
     (sonic-net#1062)
    Skip default route present in ASIC-DB but not in APP-DB. (sonic-net#1107)
     [CLI][PFCWD][Multi-ASIC] Added multi ASIC support to 'pfcwd' CLI
     (sonic-net#1102)
       [201911]  Multi asic platform config interface portchannel, show
       transceiver  (sonic-net#1087)
       [drop counters] Fix configuration for counters with lowercase
       names (sonic-net#1103)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants