Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports and remove flowtypes #49

Merged
merged 10 commits into from
Sep 7, 2022
Merged

Update imports and remove flowtypes #49

merged 10 commits into from
Sep 7, 2022

Conversation

elstonayx
Copy link
Contributor

@elstonayx elstonayx commented Aug 24, 2022

This PR removes flowtypes from the design system, and update imports that uses '.es6' to '.es6.js'.

Sanity check:

  • Check that the design system compiles properly and that components show up correctly on the webserver.

@elstonayx elstonayx changed the base branch from main to v1.1.x August 24, 2022 15:37
@cadaxapy
Copy link
Contributor

cadaxapy commented Sep 2, 2022

Should we remove(or make false) the flow-typed parameter for all components on the Metronome page?
Screen Shot 2022-09-02 at 16 36 16

@elstonayx
Copy link
Contributor Author

Should we remove(or make false) the flow-typed parameter for all components on the Metronome page? Screen Shot 2022-09-02 at 16 36 16

Hello! Yep we should, but let's do that in a separate PR instead since it's not crucial for removing the types!

@elstonayx elstonayx merged commit 4800565 into v1.1.x Sep 7, 2022
@elstonayx elstonayx deleted the remove-flowtypes branch September 7, 2022 09:29
ekratskih added a commit that referenced this pull request Sep 13, 2022
Co-authored-by: Elston Aw <elston@elstonayx.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants