V4 #26
Merged
V4 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new GitHub integration test workflow for the master and v4 branches using different PHP versions and operating systems. Removed the local .env file that contained application environment variables, these are now accessed as secrets in the new GitHub workflow for better security.
Add GitHub integration workflow and remove local .env file
The integration workflow file (.github/workflows/integration-v4.yml) was updated to use vars instead of secrets for the LOYALTY_API_ENDPOINT_URL. This change improves flexibility by allowing the URL to be updated more easily in the workflow runtime environment.
Update integration workflow to use vars for LOYALTY_API_ENDPOINT_URL
An echo has been added for the LOYALTY_API_ENDPOINT_URL environment variable in the Github action workflow file integration-v4.yml. This is useful for debugging purposes, providing visibility of the variable value during the workflow run.
These API keys used in the integration-v4 Github workflow have been removed for security purposes. The action now retrieves these keys from environment variables, ensuring more secure handling of sensitive data.
A new "environment" parameter has been added to the integration-v4.yml file. This change will
Altered assertions in ContactsFetcherTest and CardsFetcherTest to check for greater than or equal to expected counts, rather than exact match. Additionally, removed unnecessary debugging environment variable prints from integration-v4.yml in Github workflows.
Refactored the test assertions in ContactsFetcherTest, CardsFetcherTest, CardsTest, and ContactsTest files to ensure they are non-zero instead of comparing to the initial count. Also, a test method to count cards was added to the CardsTest file for better test coverage.
The PHP setup in the integration-v4.yml GitHub workflows file was updated. The version for setup-php was set to v2.30.4, the coverage was set to xdebug, and several PHP extensions (mbstring, intl,
This change is related to the PHP setup used in the GitHub Actions integration workflow. We've downgraded the "shivammathur/setup-php" action from version v2.30.4 to v2.9.0 to address compatibility issues.
The setup-php action used in the integration workflow has been updated to version 2.30.4. This change ensures that we use the latest available version, potentially benefiting from any improvements and bug fixes offered in the new release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.