Don't double-encode URLs before parsing them #33
Merged
+3
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7 (316) wasn't a bug. When someone constructs a
mvim:
URL, they should end up escaping the unsafe characters in the path twice: once for thefile:
URL (e.g.file://Users/steve/foo%20bar/baz.txt
) and again for themvim:
URL.Escaping the whole thing inside MacVim, like this fix did, breaks legit URLs. Here's an example in Python:
In ObjC, the slashes and colon aren't escaped (equally valid as what Python does) but the space does get correctly double-escaped, so same breakage: