Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for 316: URL Scheme handler not handling paths with spaces via percent escaping #7

Closed
wants to merge 1 commit into from
Closed

Bug fix for 316: URL Scheme handler not handling paths with spaces via percent escaping #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/MacVim/MMAppController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1616,6 +1616,11 @@ - (void)handleGetURLEvent:(NSAppleEventDescriptor *)event
{
NSString *urlString = [[event paramDescriptorForKeyword:keyDirectObject]
stringValue];
// Bug 316: The URL handler isn't properly handling paths with spaces
// via percent escaped encoding.
// The fix seems to be to convert the incoming string to use percent
// escaping before converting it to a NSURL.
urlString = [urlString stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
NSURL *url = [NSURL URLWithString:urlString];

// We try to be compatible with TextMate's URL scheme here, as documented
Expand Down