Skip to content

Commit

Permalink
Fix #945: fix shadow warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
borkdude committed Oct 16, 2024
1 parent 55a76e5 commit fbb8e61
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
9 changes: 5 additions & 4 deletions src/sci/impl/analyzer.cljc
Original file line number Diff line number Diff line change
Expand Up @@ -1604,8 +1604,8 @@
meth
children child-count))
stack))])
(and f-meta (:sci.impl.analyzer/invoke-constructor f-meta))
(invoke-constructor-node ctx (first f) (rest expr))
#?@(:clj [(and f-meta (:sci.impl.analyzer/invoke-constructor f-meta))
(invoke-constructor-node ctx (first f) (rest expr))])
(and (not eval?) ;; the symbol is not a binding
(symbol? f)
(or
Expand Down Expand Up @@ -1882,8 +1882,9 @@
(sci.impl.types/->Node
(faster/deref-1 v)
nil))))
(:sci.impl.analyzer/interop mv)
(analyze-interop ctx expr v)
#?@(:clj
[(:sci.impl.analyzer/interop mv)
(analyze-interop ctx expr v)])
:else v))
;; don't evaluate records, this check needs to go before map?
;; since a record is also a map
Expand Down
9 changes: 6 additions & 3 deletions src/sci/impl/resolve.cljc
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,12 @@
(with-meta
[clazz #?(:clj sym-name
:cljs (.split (str sym-name) "."))]
(if (= "new" sym-name-str)
{:sci.impl.analyzer/invoke-constructor true}
{:sci.impl.analyzer/static-access true}))
#?(:clj
(if (= "new" sym-name-str)
{:sci.impl.analyzer/invoke-constructor true}
{:sci.impl.analyzer/static-access true})
:cljs
{:sci.impl.analyzer/static-access true}))
#?(:clj
(with-meta
[clazz sym-name]
Expand Down

0 comments on commit fbb8e61

Please sign in to comment.