Support cyclic type declarations (#485) #584

joa · 2018-01-21T21:42:07Z

Using a type before its definition shouldn't trigger a no-use-before-define warning. Flow types should experience them same behavior as function declarations (they behave currently more like function expressions).

Cyclic type dependencies are common when using flow.
For instance:

type Node<T> = { head: T; tail: Node<T> }

Fixes #485

A type alias shouldn't trigger a no-use-before-define warning just like a function declaration. Cyclic type dependencies are common when using flow. For instance: type Node<T> = { head: T; tail: Node<T> } Fixes babel#485

xtuc · 2018-03-28T11:21:04Z

Sorry for the delay, we need to review your changes before we can merge this.

xtuc · 2018-03-28T11:24:16Z

lib/babylon-to-espree/toAST.js

+      node.expression = false;
+      node.params = [];
+      node.body = node.right;
+    }


Do we have some tests for the babylon-to-espress transform? That is surprising to me that this don't have any side effect?

https://github.com/babel/babel-eslint/blob/master/test/babel-eslint.js#L68

Shuliyey · 2018-04-02T08:55:00Z

👍

mdsib · 2018-06-14T20:49:58Z

Thanks for this! Is there anything stopping the merge?

mourner · 2018-07-31T14:13:05Z

@xtuc hey Sven, any news about this PR?

hzoo · 2018-09-25T18:39:39Z

Sorry, haven't been able to look at all this in a while! Thanks for the PR.

hzoo · 2018-09-25T18:49:19Z

Ok weird the test is failing on master

## The dependency [babel-eslint](https://github.com/babel/babel-eslint) was updated from `9.0.0` to `10.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v10.0.0</summary> <h1>v10.0.0</h1> Small breaking change: add a peerDependency starting from the ESLint version that added a parser feature that we were monkeypatching before (and drop that code). If already using ESLint 5 shouldn't be any different. <ul> <li>Bugfix for <code>TypeAlias</code>: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="290308427" data-permission-text="Issue title is private" data-url="babel/babel-eslint#584" href="https://urls.greenkeeper.io/babel/babel-eslint/pull/584">#584</a></li> </ul> <div class="highlight highlight-source-js"><pre>/* @flow */ type Node<T> = { head: T; tail: Node<T> } // or type File = {chunks: Array<Chunk>} type Chunk = {file: File}</pre></div> <ul> <li>Update to test against ESLint 5, add a peerDependency: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="363695123" data-permission-text="Issue title is private" data-url="babel/babel-eslint#689" href="https://urls.greenkeeper.io/babel/babel-eslint/pull/689">#689</a></li> <li>Drop monkeypatching behavior: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="363706472" data-permission-text="Issue title is private" data-url="babel/babel-eslint#690" href="https://urls.greenkeeper.io/babel/babel-eslint/pull/690">#690</a></li> </ul> </details> <details> <summary>Commits</summary> The new version differs by 5 commits. <ul> <li><a href="https://urls.greenkeeper.io/babel/babel-eslint/commit/8f78e280a22def1128cd847b73fd7f221a047ed2"><code>8f78e28</code></a> <code>10.0.0</code></li> <li><a href="https://urls.greenkeeper.io/babel/babel-eslint/commit/717fba7f5605f4dc1cc5531a7c24d5c9ab37a8a2"><code>717fba7</code></a> <code>test value should be switched</code></li> <li><a href="https://urls.greenkeeper.io/babel/babel-eslint/commit/020d012c554913fea137f4129798ce31a4896dfe"><code>020d012</code></a> <code>Treat type alias declarationlike function declaration (#584)</code></li> <li><a href="https://urls.greenkeeper.io/babel/babel-eslint/commit/b400cb1b38aaa8999d2a43f381f3ee861469ab98"><code>b400cb1</code></a> <code>Test eslint5, update peerDep (#690)</code></li> <li><a href="https://urls.greenkeeper.io/babel/babel-eslint/commit/c333bd64cb014cac8b56062421e9a5c0d28d798b"><code>c333bd6</code></a> <code>Drop old monkeypatching behavior (#689)</code></li> </ul> See the <a href="https://urls.greenkeeper.io/babel/babel-eslint/compare/6aa8b6f02ff83cfb14eae2432f226f113929a50f...8f78e280a22def1128cd847b73fd7f221a047ed2">full diff</a> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴

## The devDependency [babel-eslint](https://github.com/babel/babel-eslint) was updated from `9.0.0` to `10.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v10.0.0</summary> <h1>v10.0.0</h1> Small breaking change: add a peerDependency starting from the ESLint version that added a parser feature that we were monkeypatching before (and drop that code). If already using ESLint 5 shouldn't be any different. <ul> <li>Bugfix for <code>TypeAlias</code>: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="290308427" data-permission-text="Issue title is private" data-url="babel/babel-eslint#584" href="https://urls.greenkeeper.io/babel/babel-eslint/pull/584">#584</a></li> </ul> <div class="highlight highlight-source-js"><pre>/* @flow */ type Node<T> = { head: T; tail: Node<T> } // or type File = {chunks: Array<Chunk>} type Chunk = {file: File}</pre></div> <ul> <li>Update to test against ESLint 5, add a peerDependency: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="363695123" data-permission-text="Issue title is private" data-url="babel/babel-eslint#689" href="https://urls.greenkeeper.io/babel/babel-eslint/pull/689">#689</a></li> <li>Drop monkeypatching behavior: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="363706472" data-permission-text="Issue title is private" data-url="babel/babel-eslint#690" href="https://urls.greenkeeper.io/babel/babel-eslint/pull/690">#690</a></li> </ul> </details> <details> <summary>Commits</summary> The new version differs by 5 commits. <ul> <li><a href="https://urls.greenkeeper.io/babel/babel-eslint/commit/8f78e280a22def1128cd847b73fd7f221a047ed2"><code>8f78e28</code></a> <code>10.0.0</code></li> <li><a href="https://urls.greenkeeper.io/babel/babel-eslint/commit/717fba7f5605f4dc1cc5531a7c24d5c9ab37a8a2"><code>717fba7</code></a> <code>test value should be switched</code></li> <li><a href="https://urls.greenkeeper.io/babel/babel-eslint/commit/020d012c554913fea137f4129798ce31a4896dfe"><code>020d012</code></a> <code>Treat type alias declarationlike function declaration (#584)</code></li> <li><a href="https://urls.greenkeeper.io/babel/babel-eslint/commit/b400cb1b38aaa8999d2a43f381f3ee861469ab98"><code>b400cb1</code></a> <code>Test eslint5, update peerDep (#690)</code></li> <li><a href="https://urls.greenkeeper.io/babel/babel-eslint/commit/c333bd64cb014cac8b56062421e9a5c0d28d798b"><code>c333bd6</code></a> <code>Drop old monkeypatching behavior (#689)</code></li> </ul> See the <a href="https://urls.greenkeeper.io/babel/babel-eslint/compare/6aa8b6f02ff83cfb14eae2432f226f113929a50f...8f78e280a22def1128cd847b73fd7f221a047ed2">full diff</a> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴

pnevyk · 2018-09-27T08:50:41Z

This change (generally) breaks eslint plugins that use TypeAlias visitor. To me, changing node type from TypeAlias to FunctionDeclaration doesn't look like a correct solution (however, I have no insight into issue that is fixed by this). Is this going to be reverted?

hzoo · 2018-09-27T12:53:11Z

Yeah I think we will need to revert, was trying to look into the solution earlier

This reverts commit 020d012.

* Revert "Treat type alias declarationlike function declaration (#584)" This reverts commit 020d012.

Treat type alias declarationlike function declaration

c6c0053

A type alias shouldn't trigger a no-use-before-define warning just like a function declaration. Cyclic type dependencies are common when using flow. For instance: type Node<T> = { head: T; tail: Node<T> } Fixes babel#485

joa mentioned this pull request Jan 21, 2018

eslint warning no-use-before-define should not apply to flow types facebook/create-react-app#2103

Closed

xtuc reviewed Mar 28, 2018

View reviewed changes

daniel-wer mentioned this pull request Jul 11, 2018

Update eslint to v5, and eslint related plugins scalableminds/webknossos#2880

Closed

3 tasks

gaearon mentioned this pull request Sep 9, 2018

Enable no-use-before-define rule facebook/react#13606

Merged

hzoo merged commit 020d012 into babel:master Sep 25, 2018

hzoo mentioned this pull request Sep 25, 2018

Bump babel-eslint and remove flow supressions facebook/react#13727

Merged

hzoo mentioned this pull request Sep 26, 2018

v10.0.0: TypeError: statements is not iterable #691

Closed

pnevyk mentioned this pull request Sep 27, 2018

WIP: Bump versions of babel-eslint, eslint and eslint-config-canonical gajus/eslint-plugin-flowtype#359

Merged

hzoo added a commit that referenced this pull request Sep 27, 2018

Revert "Treat type alias declarationlike function declaration (#584)"

52e3f79

This reverts commit 020d012.

hzoo mentioned this pull request Sep 27, 2018

Revert 584 #697

Merged

hzoo added a commit that referenced this pull request Sep 27, 2018

Revert #584 (#697)

98c1f13

* Revert "Treat type alias declarationlike function declaration (#584)" This reverts commit 020d012.

This was referenced Sep 27, 2018

Update babel-eslint in / from 8.0.1 to 10.0.1 pcardune/redux-firebase-mirror#238

Open

Update 3 dependencies from npm JetBrains/ring-ui#428

Merged

renovate bot mentioned this pull request Jul 6, 2021

chore(deps): update dependency babel-eslint to v10 - autoclosed signavio/i18n#102

Closed

1 task

renovate bot mentioned this pull request Jul 14, 2021

Update dependency babel-eslint to v10 genenotebook/genenotebook#198

Merged

1 task

This was referenced Jul 22, 2021

chore(deps): update babel monorepo (major) - autoclosed scratchfoundation/scratch-audio#168

Closed

chore(deps): update babel monorepo (major) - autoclosed scratchfoundation/scratch-paint#1730

Closed

Omrisnyk mentioned this pull request Feb 4, 2024

[Snyk] Fix for 12 vulnerabilities Omrisnyk/npm-lockfiles#142

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support cyclic type declarations (#485) #584

Support cyclic type declarations (#485) #584

joa commented Jan 21, 2018

xtuc commented Mar 28, 2018

xtuc Mar 28, 2018

joa Mar 28, 2018

Shuliyey commented Apr 2, 2018

mdsib commented Jun 14, 2018

mourner commented Jul 31, 2018

hzoo commented Sep 25, 2018

hzoo commented Sep 25, 2018

pnevyk commented Sep 27, 2018

hzoo commented Sep 27, 2018

Support cyclic type declarations (#485) #584

Support cyclic type declarations (#485) #584

Conversation

joa commented Jan 21, 2018

xtuc commented Mar 28, 2018

xtuc Mar 28, 2018

Choose a reason for hiding this comment

joa Mar 28, 2018

Choose a reason for hiding this comment

Shuliyey commented Apr 2, 2018

mdsib commented Jun 14, 2018

mourner commented Jul 31, 2018

hzoo commented Sep 25, 2018

hzoo commented Sep 25, 2018

pnevyk commented Sep 27, 2018

hzoo commented Sep 27, 2018