This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use @babel/core#parse #711
Use @babel/core#parse #711
Changes from 16 commits
99be0bd
60554f1
fac8793
e550a4c
abcec07
e4fa4f8
6100fe1
f97954a
c1bb141
fae5a5d
cd7b549
1c39155
f92c9ad
3ec6148
0477350
59aed40
759ca4c
823500d
b50c2fb
37ff19e
2ab1a61
eca618d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic. Very important for toolkits that encapsulate eslint config. Thank you for adding this feature 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should probably pass through all the options that can directly influence a config:
cwd
root
rootMode
envName
configFile
babelrc
babelrcRoots
extends
env
overrides
test
include
exclude
ignore
only
It would be great to also set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated this, but I'm wondering if we do really want the config merging options here - shouldn't we be able to just provide the config loading options that would point to the config file that could then contain the config merging options? This would avoid duplication in the
.eslintrc.js
andbabel.config.js
files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
are important to have since they affect the actual process of loading config files. The rest are not strictly necessary, but it seems like support for them might as well be included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally would prefer to start with fewer rather than more options (especially since this project is already difficult to maintain), but am happy to defer to what you think is best. 👍