Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually fix 'inline' sourcemaps so they work with Webpack. #671

Merged
merged 1 commit into from
Sep 2, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,16 @@ async function loader(source, inputSourceMap, overrides) {
});
}

if (options.sourceMaps === "inline") {
// Babel has this weird behavior where if you set "inline", we
// inline the sourcemap, and set 'result.map = null'. This results
// in bad behavior from Babel since the maps get put into the code,
// which Webpack does not expect, and because the map we return to
// Webpack is null, which is also bad. To avoid that, we override the
// behavior here so "inline" just behaves like 'true'.
options.sourceMaps = true;
}

const {
cacheDirectory = null,
cacheIdentifier = JSON.stringify({
Expand Down
47 changes: 47 additions & 0 deletions test/sourcemaps.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,53 @@ test.cb("should output webpack's sourcemap", t => {
});
});

test.cb("should output webpack's sourcemap properly when set 'inline'", t => {
const config = Object.assign({}, globalConfig, {
devtool: "source-map",
output: {
path: t.context.directory,
},
module: {
rules: [
{
test: /\.jsx?/,
loader: babelLoader + "?presets[]=@babel/env&sourceMap=inline",
exclude: /node_modules/,
},
],
},
});

webpack(config, (err, stats) => {
t.is(err, null);
t.is(stats.compilation.errors.length, 0);
t.is(stats.compilation.warnings.length, 0);

fs.readdir(t.context.directory, (err, files) => {
t.is(err, null);

const map = files.filter(file => file.indexOf(".map") !== -1);

t.true(map.length > 0);

if (map.length > 0) {
fs.readFile(path.resolve(t.context.directory, map[0]), (err, data) => {
t.is(err, null);

const mapObj = JSON.parse(data.toString());

t.is(mapObj.sources[1], "webpack:///./test/fixtures/basic.js");

// Ensure that the map contains the original code, not the
// compiled src.
t.is(mapObj.sourcesContent[1].indexOf("__esModule"), -1);
t.end();
});
}
});
});
});

test.cb("should output webpack's devtoolModuleFilename option", t => {
const config = Object.assign({}, globalConfig, {
devtool: "source-map",
Expand Down