-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema validation #822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What should be done to get it merged @JLHwung ? |
Hi @ogonkov, generally we have two-approval policy on merging PRs. Let's wait for a longer while. Thanks for your patience. |
@JLHwung Can we invite someone here to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Options is validated programmatically
What is the new behavior?
Options validated through schema, webpack will assist if given option is not match schema
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Other information:
Closes #749