Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use md5 hash for caching on node v17 #918

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Use md5 hash for caching on node v17 #918

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2748be
Fixing outdated hash algorithm
Reptarsrage Oct 20, 2021
353b879
Adding new hashType configuration option
Reptarsrage Oct 20, 2021
7cc7d2a
Switching hash type based on major node version
Reptarsrage Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,14 @@ const write = async function (filename, compress, result) {
* @return {String}
*/
const filename = function (source, identifier, options) {
const hash = crypto.createHash("md4");
// md4 hashing is not supported starting with node v17.0.0
const majorNodeVersion = parseInt(process.versions.node.split(".")[0], 10);
let hashType = "md4";
if (majorNodeVersion >= 17) {
hashType = "md5";
}

const hash = crypto.createHash(hashType);

const contents = JSON.stringify({ source, options, identifier });

Expand Down