Pass external dependencies from Babel to Webpack #971

nicolo-ribaudo · 2022-11-01T10:39:36Z

Please check if the PR fulfills these requirements

Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?

We added support for externalDependencies in Babel 7.12.0, but we never properly wired it in babel-loader. babel-loader must forward the list of external dependencies from @babel/core to webpack, so that webpack knows which files to watch and when to re-run Babel.

Does this PR introduce a breaking change?

Yes
No

nicolo-ribaudo · 2022-11-01T10:45:29Z

I plan to backport this to v8, since we released v9 just a few days ago.

JLHwung · 2022-11-01T15:22:06Z

src/index.js


+      externalDependencies?.forEach(dep => this.addDependency(dep));


Do we use optional chaining here because we can't control the return type of overrides.result? If so we might consider convert babel-loader to ts and publish typings.

Yeah, I added ? because current overrides.result functions probably don't return externalDependencies, if they replace the result object.

Backport of 6348e1c

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [babel-loader](https://github.com/babel/babel-loader) | [`8.2.5` -> `8.3.0`](https://renovatebot.com/diffs/npm/babel-loader/8.2.5/8.3.0) | [![age](https://badges.renovateapi.com/packages/npm/babel-loader/8.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/babel-loader/8.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/babel-loader/8.3.0/compatibility-slim/8.2.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/babel-loader/8.3.0/confidence-slim/8.2.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>babel/babel-loader</summary> ### [`v8.3.0`](https://github.com/babel/babel-loader/releases/tag/v8.3.0) [Compare Source](https://github.com/babel/babel-loader/compare/v8.2.5...v8.3.0) #### New features - Pass external dependencies from Babel to Webpack by [@nicolo-ribaudo](https://github.com/nicolo-ribaudo) in [https://github.com/babel/babel-loader/pull/971](https://github.com/babel/babel-loader/pull/971) **Full Changelog**: babel/babel-loader@v8.2.5...v8.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [babel-loader](https://github.com/babel/babel-loader) | [`8.2.5` -> `8.3.0`](https://renovatebot.com/diffs/npm/babel-loader/8.2.5/8.3.0) | [![age](https://badges.renovateapi.com/packages/npm/babel-loader/8.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/babel-loader/8.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/babel-loader/8.3.0/compatibility-slim/8.2.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/babel-loader/8.3.0/confidence-slim/8.2.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>babel/babel-loader</summary> ### [`v8.3.0`](https://github.com/babel/babel-loader/releases/tag/v8.3.0) [Compare Source](https://github.com/babel/babel-loader/compare/v8.2.5...v8.3.0) #### New features - Pass external dependencies from Babel to Webpack by [@nicolo-ribaudo](https://github.com/nicolo-ribaudo) in [https://github.com/babel/babel-loader/pull/971](https://github.com/babel/babel-loader/pull/971) **Full Changelog**: babel/babel-loader@v8.2.5...v8.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/dooboolab/dooboo-ui).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [babel-loader](https://github.com/babel/babel-loader) | [`8.2.5` -> `8.3.0`](https://renovatebot.com/diffs/npm/babel-loader/8.2.5/8.3.0) | [![age](https://badges.renovateapi.com/packages/npm/babel-loader/8.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/babel-loader/8.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/babel-loader/8.3.0/compatibility-slim/8.2.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/babel-loader/8.3.0/confidence-slim/8.2.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>babel/babel-loader</summary> ### [`v8.3.0`](https://github.com/babel/babel-loader/releases/tag/v8.3.0) [Compare Source](https://github.com/babel/babel-loader/compare/v8.2.5...v8.3.0) #### New features - Pass external dependencies from Babel to Webpack by [@nicolo-ribaudo](https://github.com/nicolo-ribaudo) in [https://github.com/babel/babel-loader/pull/971](https://github.com/babel/babel-loader/pull/971) **Full Changelog**: babel/babel-loader@v8.2.5...v8.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pass external dependencies from Babel to Webpack

1c43f55

JLHwung approved these changes Nov 1, 2022

View reviewed changes

nicolo-ribaudo merged commit 6348e1c into babel:main Nov 1, 2022

nicolo-ribaudo added a commit to nicolo-ribaudo/babel-loader that referenced this pull request Nov 3, 2022

Pass external dependencies from Babel to Webpack (babel#971)

0f80d9d

nicolo-ribaudo added a commit to nicolo-ribaudo/babel-loader that referenced this pull request Nov 3, 2022

Pass external dependencies from Babel to Webpack (babel#971)

493ac6c

Backport of 6348e1c

liuxingbaoyu mentioned this pull request Feb 21, 2023

Refresh time is too slow in expo react-native project after upgrade #983

Closed

renovate bot mentioned this pull request Jun 15, 2023

Chore: Update devDependencies 🆙 (major) crystal-ball/react-application-prototype#391

Open

1 task

This was referenced Feb 26, 2024

Bump babel-loader from 7.1.5 to 9.1.3 somabc/my-portfolio#7

Merged

Bump babel-loader from 7.1.5 to 9.1.3 somabc/notes-app-api#5

Merged

renovate bot mentioned this pull request May 9, 2024

fix(deps): update all major dependencies (major) kmkzt/react-typescript-starter#88

Open

1 task

renovate bot mentioned this pull request Sep 17, 2024

chore(deps): update all major dependencies (major) kmkzt/comlink-three-example#5

Open

1 task

Sheitak mentioned this pull request Sep 18, 2024

[Snyk] Upgrade: apexcharts, babel-loader, fusioncharts Sheitak/weather-graphics-monitoring#973

Open

andreaeliasc mentioned this pull request Sep 19, 2024

[Snyk] Upgrade: , , , react, react-dom, babel-loader, bootstrap, react-bootstrap, react-pro-sidebar, react-redux, react-router-dom, react-scripts, redux, redux-form, redux-saga pablosao/UVG-CC3061-Colecciones-Biologia-Front#127

Open

Sheitak mentioned this pull request Sep 19, 2024

[Snyk] Upgrade: apexcharts, babel-loader, fusioncharts Sheitak/weather-graphics-monitoring#974

Open

richyhoopd mentioned this pull request Sep 19, 2024

[Snyk] Upgrade: , , , react, react-dom, babel-loader, eslint-config-airbnb, eslint-plugin-import, eslint-plugin-jsx-a11y, eslint-plugin-react richyhoopd/Video-App#1213

Open

andreaeliasc mentioned this pull request Sep 20, 2024

[Snyk] Upgrade: , , , react, react-dom, babel-loader, bootstrap, react-bootstrap, react-pro-sidebar, react-redux, react-router-dom, react-scripts, redux, redux-form, redux-saga pablosao/UVG-CC3061-Colecciones-Biologia-Front#128

Open

This was referenced Sep 20, 2024

[Snyk] Upgrade: apexcharts, babel-loader, fusioncharts Sheitak/weather-graphics-monitoring#975

Open

[Snyk] Upgrade: apexcharts, babel-loader, fusioncharts Sheitak/weather-graphics-monitoring#976

Open

richyhoopd mentioned this pull request Sep 21, 2024

[Snyk] Upgrade: , , , react, react-dom, babel-loader, eslint-config-airbnb, eslint-plugin-import, eslint-plugin-jsx-a11y, eslint-plugin-react richyhoopd/Video-App#1214

Open

This was referenced Sep 22, 2024

[Snyk] Upgrade: apexcharts, babel-loader, fusioncharts Sheitak/weather-graphics-monitoring#977

Open

[Snyk] Upgrade: apexcharts, babel-loader, fusioncharts Sheitak/weather-graphics-monitoring#978

Open

richyhoopd mentioned this pull request Sep 23, 2024

[Snyk] Upgrade: , , , react, react-dom, babel-loader, eslint-config-airbnb, eslint-plugin-import, eslint-plugin-jsx-a11y, eslint-plugin-react richyhoopd/Video-App#1215

Open

jonkiky mentioned this pull request Oct 1, 2024

[Snyk] Upgrade babel-loader from 8.0.5 to 8.3.0 CBIIT/INS-WebPortal#342

Closed

This was referenced Oct 26, 2024

[Snyk] Upgrade babel-loader from 8.1.0 to 8.4.1 Sheitak/weather-graphics-monitoring#1026

Open

[Snyk] Upgrade babel-loader from 8.1.0 to 8.4.1 Sheitak/weather-graphics-monitoring#1029

Open

s-w-high mentioned this pull request Nov 3, 2024

[Snyk] Upgrade babel-loader from 8.1.0 to 8.4.1 s-w-high/my-react-js-tutorials#1443

Open

Sheitak mentioned this pull request Nov 10, 2024

[Snyk] Upgrade babel-loader from 8.1.0 to 8.4.1 Sheitak/weather-graphics-monitoring#1032

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pass external dependencies from Babel to Webpack #971

Pass external dependencies from Babel to Webpack #971

nicolo-ribaudo commented Nov 1, 2022 •

edited

Loading

nicolo-ribaudo commented Nov 1, 2022

JLHwung Nov 1, 2022

nicolo-ribaudo Nov 1, 2022


		externalDependencies?.forEach(dep => this.addDependency(dep));

Pass external dependencies from Babel to Webpack #971

Pass external dependencies from Babel to Webpack #971

Conversation

nicolo-ribaudo commented Nov 1, 2022 • edited Loading

nicolo-ribaudo commented Nov 1, 2022

JLHwung Nov 1, 2022

Choose a reason for hiding this comment

nicolo-ribaudo Nov 1, 2022

Choose a reason for hiding this comment

nicolo-ribaudo commented Nov 1, 2022 •

edited

Loading