Prettify. #183
Prettify. #183
Conversation
|
Should we enable prettifier? |
|
@danez Yeah, I think we could prettify not separate fragments, but all the stuff. The only thing - we must be consistent with babel and babylon prettify branches. |
|
Could we import the rules defined in https://github.com/babel/babel/pull/5413/files#diff-1dc6ee56b778cd91e0327b52aaeaa1b9? We will then include theses rules by default in babel-eslint-config. |
|
@xtuc Sure 👍 |
package.json
Outdated
| "prettier --trailing-comma all --write \"scripts/*.js\"", | ||
| "git add" | ||
| ], | ||
| "test/*.js": [ |
There was a problem hiding this comment.
Probably want to exclude expected.js?
There was a problem hiding this comment.
@existentialism test/*.js will cover just files inside, but not below test directory, so fixtures/debug-fixtures shouldn't be affected unlike test/**/*.js
package.json
Outdated
| }, | ||
| "lint-staged": { | ||
| "src/*.js": [ | ||
| "prettier --trailing-comma all --write \"src/*.js\"", |
There was a problem hiding this comment.
Can omit the \"src/*.js\" as --write will replace
There was a problem hiding this comment.
Also, can probably combine these to:
{
"lint-staged": {
"{src,scripts}/**/*.js": [
"prettier --trailing-comma all --write",
"git add"
]
}
}There was a problem hiding this comment.
@existentialism thanks 👍
|
@yavorsky mind bumping to latest prettier and rerunning? |
existentialism
force-pushed
the
2.0-prettify-long
branch
from
6951d23 to
e440ae5
Compare
Codecov Report
@@ Coverage Diff @@
## 2.0 #183 +/- ##
=========================================
- Coverage 94.7% 94.38% -0.33%
=========================================
Files 3 3
Lines 189 196 +7
Branches 55 58 +3
=========================================
+ Hits 179 185 +6
- Misses 7 8 +1
Partials 3 3
Continue to review full report at Codecov.
|
No description provided.