This repository has been archived by the owner on May 11, 2018. It is now read-only.
[1.x] Add polyfills for ES6 static Object methods #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latest yarn produced new yarn.lock
existentialism
approved these changes
Oct 13, 2017
|
@danez let's port this to babel/babel (the new 2.x) as well |
|
Oh it was moved already? Didn't know about that. Will do it! |
This functions do exist in ES5, but we still need to load the polyfills, as they now accept different values
|
@danez we moved the code but i failed at moving issues correctly 😛 (need to move open issues + some closed issues, I only moved older issues without a label) |
existentialism
force-pushed
the
add-object-static
branch
from
7c294a7 to
52a35ee
Compare
This was referenced Oct 17, 2017
This was referenced Feb 2, 2018
This was referenced Apr 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions do exist in ES5, but we still need to load the polyfills in ES5 browsers (like IE11), as the functions work sligthly different in ES5 vs ES6
We noticed this when trying to basically run the following code which throws in IE11 but works in latest Chrome:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys#Notes
Can also port to 2.0 if this is okay.
//cc @SevInf