This repository has been archived by the owner on May 19, 2018. It is now read-only.
Allow keywords in object/class property names with Flow type parameters #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 94.48% (diff: 100%)@@ master #145 diff @@
==========================================
Files 19 19
Lines 3111 3118 +7
Methods 327 329 +2
Messages 0 0
Branches 818 818
==========================================
+ Hits 2939 2946 +7
Misses 94 94
Partials 78 78
|
danez
approved these changes
Oct 14, 2016
kristofdegrave
pushed a commit
to kristofdegrave/babylon
that referenced
this pull request
Oct 27, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #48
Certain keywords like
delete,yield,dosetbeforeExpr: true. These updateexprAllowedin state. Ultimately, it results in the JSX plugin picking up the<token due toexprAllowed.This fix prevents the JSX plugin from reading tokens in property names, allowing the Flow plugin to pick them up instead.