This repository has been archived by the owner on May 19, 2018. It is now read-only.
Add support for flow type spread #418
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| type A = { | ||
| ...any, | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| { | ||
| "type": "File", | ||
| "start": 0, | ||
| "end": 22, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 2 | ||
| } | ||
| }, | ||
| "program": { | ||
| "type": "Program", | ||
| "start": 0, | ||
| "end": 22, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 2 | ||
| } | ||
| }, | ||
| "sourceType": "module", | ||
| "body": [ | ||
| { | ||
| "type": "TypeAlias", | ||
| "start": 0, | ||
| "end": 22, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 2 | ||
| } | ||
| }, | ||
| "id": { | ||
| "type": "Identifier", | ||
| "start": 5, | ||
| "end": 6, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 5 | ||
| }, | ||
| "end": { | ||
| "line": 1, | ||
| "column": 6 | ||
| }, | ||
| "identifierName": "A" | ||
| }, | ||
| "name": "A" | ||
| }, | ||
| "typeParameters": null, | ||
| "right": { | ||
| "type": "ObjectTypeAnnotation", | ||
| "start": 9, | ||
| "end": 21, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 9 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 1 | ||
| } | ||
| }, | ||
| "callProperties": [], | ||
| "properties": [ | ||
| { | ||
| "type": "ObjectTypeSpreadProperty", | ||
| "start": 12, | ||
| "end": 19, | ||
| "loc": { | ||
| "start": { | ||
| "line": 2, | ||
| "column": 1 | ||
| }, | ||
| "end": { | ||
| "line": 2, | ||
| "column": 8 | ||
| } | ||
| }, | ||
| "argument": { | ||
| "type": "AnyTypeAnnotation", | ||
| "start": 15, | ||
| "end": 18, | ||
| "loc": { | ||
| "start": { | ||
| "line": 2, | ||
| "column": 4 | ||
| }, | ||
| "end": { | ||
| "line": 2, | ||
| "column": 7 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "indexers": [], | ||
| "exact": false | ||
| } | ||
| } | ||
| ], | ||
| "directives": [] | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| type A = { | ||
| p: {}, | ||
| ...{}, | ||
| }; | ||
|
There was a problem hiding this comment. This should not parse I think. Probably related to what @gabelevi wrote. At least flow is also throwing errors: http://astexplorer.net/#/gist/7703a4fb36053ce507e10d396c5f7d71/c2f5ba5c1048c1e8bade34bebccc16efa44d7367 There was a problem hiding this comment. This should parse. How are you testing? Gabe's comment is that parsePrimaryType is actually too restrictive. We also parse non-primary types in this position, like unions. E.g., There was a problem hiding this comment. Oh okay sorry. I see astexplorer uses flow 0.40 which supports it spreading only for Identifiers? There was a problem hiding this comment. Right, we "reserved" the syntax in 0.40, but 0.42 extends support to all type syntax and adds support. There was a problem hiding this comment. Yeah, PR for astexplorer hasn't been merged yet fkling/astexplorer#208 There was a problem hiding this comment. But https://flowtype.org/try/ should work and it has an AST tab There was a problem hiding this comment. We should see if we can setup greenkeeper or a bot to update the package + yarn @fkling There was a problem hiding this comment. I think felix is working on this. fkling/astexplorer#197 |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,175 @@ | ||
| { | ||
| "type": "File", | ||
| "start": 0, | ||
| "end": 29, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 4, | ||
| "column": 2 | ||
| } | ||
| }, | ||
| "program": { | ||
| "type": "Program", | ||
| "start": 0, | ||
| "end": 29, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 4, | ||
| "column": 2 | ||
| } | ||
| }, | ||
| "sourceType": "module", | ||
| "body": [ | ||
| { | ||
| "type": "TypeAlias", | ||
| "start": 0, | ||
| "end": 29, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 0 | ||
| }, | ||
| "end": { | ||
| "line": 4, | ||
| "column": 2 | ||
| } | ||
| }, | ||
| "id": { | ||
| "type": "Identifier", | ||
| "start": 5, | ||
| "end": 6, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 5 | ||
| }, | ||
| "end": { | ||
| "line": 1, | ||
| "column": 6 | ||
| }, | ||
| "identifierName": "A" | ||
| }, | ||
| "name": "A" | ||
| }, | ||
| "typeParameters": null, | ||
| "right": { | ||
| "type": "ObjectTypeAnnotation", | ||
| "start": 9, | ||
| "end": 28, | ||
| "loc": { | ||
| "start": { | ||
| "line": 1, | ||
| "column": 9 | ||
| }, | ||
| "end": { | ||
| "line": 4, | ||
| "column": 1 | ||
| } | ||
| }, | ||
| "callProperties": [], | ||
| "properties": [ | ||
| { | ||
| "type": "ObjectTypeProperty", | ||
| "start": 12, | ||
| "end": 18, | ||
| "loc": { | ||
| "start": { | ||
| "line": 2, | ||
| "column": 1 | ||
| }, | ||
| "end": { | ||
| "line": 2, | ||
| "column": 7 | ||
| } | ||
| }, | ||
| "key": { | ||
| "type": "Identifier", | ||
| "start": 12, | ||
| "end": 13, | ||
| "loc": { | ||
| "start": { | ||
| "line": 2, | ||
| "column": 1 | ||
| }, | ||
| "end": { | ||
| "line": 2, | ||
| "column": 2 | ||
| }, | ||
| "identifierName": "p" | ||
| }, | ||
| "name": "p" | ||
| }, | ||
| "value": { | ||
| "type": "ObjectTypeAnnotation", | ||
| "start": 15, | ||
| "end": 17, | ||
| "loc": { | ||
| "start": { | ||
| "line": 2, | ||
| "column": 4 | ||
| }, | ||
| "end": { | ||
| "line": 2, | ||
| "column": 6 | ||
| } | ||
| }, | ||
| "callProperties": [], | ||
| "properties": [], | ||
| "indexers": [], | ||
| "exact": false | ||
| }, | ||
| "optional": false, | ||
| "static": false, | ||
| "variance": null | ||
| }, | ||
| { | ||
| "type": "ObjectTypeSpreadProperty", | ||
| "start": 20, | ||
| "end": 26, | ||
| "loc": { | ||
| "start": { | ||
| "line": 3, | ||
| "column": 1 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 7 | ||
| } | ||
| }, | ||
| "argument": { | ||
| "type": "ObjectTypeAnnotation", | ||
| "start": 23, | ||
| "end": 25, | ||
| "loc": { | ||
| "start": { | ||
| "line": 3, | ||
| "column": 4 | ||
| }, | ||
| "end": { | ||
| "line": 3, | ||
| "column": 6 | ||
| } | ||
| }, | ||
| "callProperties": [], | ||
| "properties": [], | ||
| "indexers": [], | ||
| "exact": false | ||
| } | ||
| } | ||
| ], | ||
| "indexers": [], | ||
| "exact": false | ||
| } | ||
| } | ||
| ], | ||
| "directives": [] | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| interface A { | ||
| ...any, | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "throws": "Spread operator cannnot appear in class or interface definitions (2:1)" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyis also not allowed here it seems, flow is throwing an error. Seems to also happen for all primitive types:number, string, boolean, any, null, ...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should parse. How are you testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay was testing on astexplorer, which was a bad idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, no worries. Per your initial comment, the typing support is incomplete, but eventually we will also support spreading
string(implicitly promotes toStringinstance, which has no own properties).