Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config data from package.json #185

Closed
jamesplease opened this issue Jul 30, 2015 · 9 comments
Closed

Remove config data from package.json #185

jamesplease opened this issue Jul 30, 2015 · 9 comments
Labels

Comments

@jamesplease
Copy link
Member

I originally put the boilerplate config in the package.json per @thejameskyle's suggestion. @megawac thinks it'd be better to put it in the gulpfile.

I'm fine either way, honestly. Any strong opinions here?

@jamiebuilds
Copy link
Contributor

No strong opinions

@jamesplease
Copy link
Member Author

@megawac what you think?

@megawac
Copy link
Contributor

megawac commented Jul 31, 2015

I'd like to see it moved elsewhere - probably just gulpfile IMO

@jamiebuilds
Copy link
Contributor

Yeah the gulpfile is good

@jamesplease
Copy link
Member Author

k will change

jamesplease added a commit that referenced this issue Aug 1, 2015
@jamesplease jamesplease changed the title Remove config data from package.json? Remove config data from package.json Aug 5, 2015
@jamesplease
Copy link
Member Author

Prob depends on mochajs/mocha#1457 (comment)

@jamesplease
Copy link
Member Author

@thejameskyle / @megawac I think I've got three choices:

  1. leave it the way that it is
  2. duplicate the mocha globals in two places (Gulpfile and browserify setup file)
  3. create an external file just for the mocha configuration

Thoughts?

@jamesplease jamesplease added this to the post-v6.0.0 milestone Oct 10, 2015
@paulfalgout
Copy link
Member

4: I think you should have an external json file for the mocha globals and the eslintrc file in the test directory should extend from it so you're not setting them there as well.

@jamesplease
Copy link
Member Author

I'm going to close this because of @paulfalgout 's awesome change made here ceb2941

If anyone else has any ideas for further ways to optimize the configuration, do let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants