Add authentication to the Web UI #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
rossjones
reviewed
Mar 27, 2024
frrist
reviewed
Mar 27, 2024
| @@ -34,7 +33,6 @@ func NewEndpoint(params EndpointParams) *Endpoint { | |||
| // JSON group | |||
| g := e.router.Group("/api/v1/orchestrator") | |||
| g.Use(middleware.SetContentType(echo.MIMEApplicationJSON)) | |||
| g.Use(echo_middleware.CORS()) | |||
There was a problem hiding this comment.
why did we need to remove this? I don't have a problem with the change - just curious
There was a problem hiding this comment.
Previously this was done on a per-endpoint basis, but this isn't necessary – we can just blanket add it to all endpoints. This also has the added benefit that CORS requests will return successfully without needing to invoke the authz handler.
This commit hooks up the Web UI to use our authentication APIs. It can now query for a list of acceptable authentication methods and show the user a web form for filling out the required credentials. The UI will monitor requests and if it detects an Unauthorized status will immediately open the auth flow. So as with the CLI, auth happens automagically when required and not otherwise.
|
It builds now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit hooks up the Web UI to use our authentication APIs. It can now query for a list of acceptable authentication methods and show the user a web form for filling out the required credentials.
The UI will monitor requests and if it detects an Unauthorized status will immediately open the auth flow. So as with the CLI, auth happens automagically when required and not otherwise.
With default authorization policy in place, which doesn't require authz to use read-only APIs, the user won't see any authentication because it is not required.
But, for example, with a username/password and non-anon policy in place, the user will be redirected to a page to provide credentials:
The system remains entirely flexible, and the required credentials is still controlled by the auth policy. So with the "shared secret" auth policy used by the Marketplace deployment, the user will see:
Resolves #3679
Resolves #3641
Resolves https://github.com/bacalhau-project/expanso-planning/issues/668
Resolves https://github.com/bacalhau-project/expanso-planning/issues/669