-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add evaluation watcher and enable atomic enqueues #3998
Conversation
Important Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
store jobstore.Store | ||
broker *evaluation.InMemoryBroker | ||
watcher *evaluation.Watcher | ||
ctx context.Context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in 5dba032
In many places we update the state of jobs or executions, create an evaluation, and then enqueue the evaluation to the broker. The creation and enqueue of evaluations is not atomic. This can result in a lot of edge cases and potentially dangling or stale jobs and executions due to failure to trigger their re-evaluation.
This PR fixes this by implementing a data store watcher the listens for created evaluations and auto-enqueue those evaluations to the broker.
What is left is backfill of non-terminal evaluations at startup which will be tracked by #3999
Closes #3972