Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update Dependencies, Linting, and TypeScript #296

Merged
merged 21 commits into from
Aug 13, 2024
Merged

Conversation

bachmacintosh
Copy link
Owner

@bachmacintosh bachmacintosh commented Aug 12, 2024

Description

This PR is a one-shot at updating all of the devDependencies, switching the package manager to PNPM, updating ESLint/typescript-eslint and using a shared config, and updating the TypeScript development version alongside widening the supported TypeScript versions.

Any changes to code are merely side-effects from updated linting rules. No logic will change as part of this PR. That said, it will mean a patch version will go out just in case.

Related Issue(s) / Pull Request(s)

None

Nature of Pull Request

This Pull Request:

  • Adds/Updates Type(s) described in the WaniKani API Docs
  • Adds/Updates Type(s) provided by the wanikani-api-types package itself
  • Adds/Updates constants or other variables provided by the package
  • Adds/Updates Helper Functions/Type Guards provided by the package
  • Updates Documentation
  • Updates Project and/or Community Health files (e.g. README, GitHub Actions, etc.)

Its changes constitutes a:

  • Non-code change (i.e. no version bump)
  • Bug Fix or Other Small Changes (i.e. patch version bump)
  • Forward-compatible Enhancement (i.e. minor version bump)
  • ⚠️ BREAKING CHANGE regarding TypeScript, Package, and/or WaniKani API version(s) (i.e. MAJOR version bump)

Additional Info

None

Contribution Terms

I understand that by submitting this Pull Request:

Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
@bachmacintosh bachmacintosh added the dependencies Updates to the library's dependencies label Aug 12, 2024
@bachmacintosh bachmacintosh marked this pull request as ready for review August 12, 2024 21:58
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
@bachmacintosh bachmacintosh marked this pull request as draft August 12, 2024 22:06
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
@bachmacintosh bachmacintosh marked this pull request as ready for review August 13, 2024 15:51
@bachmacintosh bachmacintosh marked this pull request as draft August 13, 2024 15:52
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
@bachmacintosh bachmacintosh marked this pull request as ready for review August 13, 2024 19:01
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (177c8e7) to head (f1db756).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   99.54%   99.21%   -0.33%     
==========================================
  Files           4       14      +10     
  Lines        2836      892    -1944     
  Branches      135      156      +21     
==========================================
- Hits         2823      885    -1938     
+ Misses         13        7       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Collin Bachman <3395010+bachmacintosh@users.noreply.github.com>
@bachmacintosh bachmacintosh merged commit 69406f2 into main Aug 13, 2024
4 checks passed
@bachmacintosh bachmacintosh deleted the update-deps branch August 13, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates to the library's dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant