-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database functions fail if db_password contains special characters #181
Labels
Comments
This was referenced Apr 8, 2022
Left a review requesting changes. |
@BWPanda - done all the |
Thanks so much for this @yorkshire-pudding! Did a final review, made one small change I didn't notice before, and merged! |
ghost
removed
the
pr: needs review
label
May 19, 2022
yorkshire-pudding
added a commit
to yorkshire-pudding/bee
that referenced
this issue
Jul 30, 2024
bugfolder
pushed a commit
to bugfolder/bee
that referenced
this issue
Jul 31, 2024
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This also applies to db_name and db_username but these are less likely to have special characters.
For the purposes of Backdrop where
rawurlencode
is used, special means anything exceptA-Z, a-z, 0-1, - _ . ~
https://www.php.net/manual/en/function.rawurlencode.php
Steps to reproduce
install
,db-import
,db-export
,sql
, orstatus --show-password
Expected result works as normal
Actual results
install
,db-import
,db-export
,sql
will all failstatus --show-password
will show the encoded passwordThe backdrop GUI installer
core/install.php
, powered bycore/includes/install.inc
, usesrawurlencode()
for db_name, db_username and db_password so what is stored insettings.php
has these values encoded.If the
rawurldecode()
function is not used to read the database information stored insettings.php
then the value returned will be encoded and so won't match the actual DB password.The text was updated successfully, but these errors were encountered: