Issue #195: Add support for --uri option. #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorkshire-pudding
changed the title
yorkshire-pudding
requested changes
Oct 31, 2022
There was a problem hiding this comment.
@quicksketch
The suggested change fixes the error I encountered at #195 (comment)
Please also see my query regarding URI vs URL at the same comment. I don't mind if there is a good reason for using uri such as continuity for drush users, but if not, I think url may be clearer and would be consistent with the language used in settings.php.
|
|
||
| if ($_bee_options['uri']) { | ||
| $uri_parts = parse_url($_bee_options['uri']); | ||
| $_SERVER['HTTP_HOST'] = $uri_parts['host'] . ($uri_parts['port'] ? ':' . $uri_parts['port'] : ''); |
There was a problem hiding this comment.
Suggested change
| $_SERVER['HTTP_HOST'] = $uri_parts['host'] . ($uri_parts['port'] ? ':' . $uri_parts['port'] : ''); | |
| $_SERVER['HTTP_HOST'] = $uri_parts['host'] . (isset($uri_parts['port']) ? ':' . $uri_parts['port'] : ''); |
This gets rid of the errors if no port is used.
|
Agreed with @quicksketch to close this in favour of new PR from me with revisions included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work to support --uri option: #195
To test:
uli:bee --uri=https://example.com uliUsing https vs. http, sub-directories, and port numbers should all work.