Add support for downloading only security updates to the update command
#349
Conversation
…mand. (backdrop-contrib#300) This adds support for a `--security-only` flag to allow updates to be run just for modules with security releases. This also adds a way to report on the avaiable updates without actually running them, as well as an alternate output format that supports just listing the modules names. This mimics the behavior of `drush pm-updatestatus --format=list` which is useful for feeding the output to another process that actually runs the output, like an Ansible playbook.
|
Hi @anemirovsky - thanks for this contribution. I like the idea of the update status and this is better than currently where it shows updates and then asks you to confirm, so you enter 'n'. However, I think it should be a separate command within this update group rather than options in the update command. Please can you remove from this pull request and do a separate pull request for the update status command against issue #350 - an issue I've created for this. I've had a quick look at the security element and it looks ok, but I'll test and do a thorough review once the other element is removed. By the way, if you add |
separate command.
|
I've updated this PR to include just the |
There was a problem hiding this comment.
I've tested this and it works perfectly. Thank you.
There are a couple of minor enhancements suggested: an example of using this, and adding a short version of this option
Also, I've fixed a bug that arose from a recent change in Backdrop that was causing the tests to fail (minor change in commands/dblog.bee.inc) - if you can rebase your branch so it includes that change then the tests should pass. At present, we don't have any tests for this feature, but we want to ensure that any changes we make don't break existing functionality.
|
Done, thank you! |
yorkshire-pudding
changed the title
update com…update command
yorkshire-pudding
merged commit dfd8683
into
backdrop-contrib:issue-111-update-command
Fixes #300
Add support for downloading only security updates to the
updatecommand.This adds support for a
--security-onlyflag to allow updates to be run just for modules with security releases.This also adds a way to report on the avaiable updates without actually running them, as well as an alternate output format that supports just listing the modules names. This mimics the behavior ofdrush pm-updatestatus --format=listwhich is useful for feeding the output to another process that actually runs the output, like an Ansible playbook.I'm not sure if it makes sense to combine the--report-onlyand--output-formatinto theupdatecommand rather than adding a separateupdatelistcommand. I started with a separate one but realized so much of the code is the same. Happy to split it out if that's preferred, though.