Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy_term's property vocabulary must be a required property #171

Closed
argiepiano opened this issue Mar 28, 2024 · 3 comments · Fixed by #172
Closed

taxonomy_term's property vocabulary must be a required property #171

argiepiano opened this issue Mar 28, 2024 · 3 comments · Fixed by #172

Comments

@argiepiano
Copy link
Collaborator

argiepiano commented Mar 28, 2024

A year or two ago, when I added a special wrapper for Vocabularies (since they are not entities in Backdrop, like they were in Drupal 7), I missed a single line for the taxonomy_term's vocabulary property info: 'required' => TRUE.

This omission causes Rules not to show the vocabulary selection form element for the action "Create a new Entity". See Rules' issue 210.

BTW, In D7, the vocabulary property is required, and it also should be in Backdrop. PR coming.

@argiepiano
Copy link
Collaborator Author

argiepiano commented Mar 28, 2024

@bugfolder, @laryn, @hosef, PR provided.

To test:

  1. Install Rules and Rules UI
  2. Create a rule that reacts to a new node being created (in fact any reaction would work)
  3. Add an action "Create a new entity", then select "Taxonomy term" and click "Continue".
  4. At this point, before applying the PR, you won't be prompted to select a vocabulary for the new taxonomy term (which is a bug)
  5. Apply the PR and repeat all steps from number 2. This time you should be prompted to provide a vocabulary (as expected).

Thanks!

@argiepiano
Copy link
Collaborator Author

PS: the test failure is produced by another bug, see issue #164

It'd be great if you could review that one too, so that we can do a new release.

@argiepiano argiepiano changed the title Property info for taxonomy_term must make vocabulary a required property taxonomy_term's property vocabulary must be a required property Mar 28, 2024
laryn pushed a commit that referenced this issue Mar 28, 2024
@laryn
Copy link
Member

laryn commented Mar 28, 2024

Merged the other change and tests pass here, too:
CleanShot 2024-03-28 at 12 56 18@2x

LGTM, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants