Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check logic in function _simplesamlphp_auth_isEnabled() #15

Closed
laryn opened this issue Feb 10, 2023 · 0 comments · Fixed by #16
Closed

Check logic in function _simplesamlphp_auth_isEnabled() #15

laryn opened this issue Feb 10, 2023 · 0 comments · Fixed by #16

Comments

@laryn
Copy link
Member

laryn commented Feb 10, 2023

On a local while running some tests I am seeing this:

Error: Call to a member function isAuthenticated() on null in simplesamlphp_auth_user_insert() (line 374 of /app/web/modules/contrib/simplesamlphp_auth/simplesamlphp_auth.module).

I have the module enabled but the "activated" checkbox unchecked. I think maybe the logic in _simplesamlphp_auth_isEnabled() needs some slight tweaking. I'll test something and make a PR for your consideration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #15: Make sure to respect the 'activated' setting. laryn/simplesamlphp_auth
1 participant
@laryn