Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleSAML authenticated admin users cannot create other users #26

Closed
laryn opened this issue Apr 4, 2023 · 1 comment · Fixed by #31
Closed

SimpleSAML authenticated admin users cannot create other users #26

laryn opened this issue Apr 4, 2023 · 1 comment · Fixed by #31

Comments

@laryn
Copy link
Member

laryn commented Apr 4, 2023 •
edited
Loading

Original Drupal issue with a patch that appears to be working well though I haven't ported the patch yet. By Rich Burke (richburke), chrisgross, Cleber Gasparoto (chgasparoto), Vitor Machado (vmachado), and Brian Osborne (bkosborne).

drupal7-simplesamlphp_auth-admin-users-cannot-other-users-9291915-11-with-early-return.patch.txt

When a user that's been authenticated through SSO tries to create other users, those users have the name & email address of the admin applied to them. This results in a DB constraint error on the user name.
laryn added a commit to laryn/simplesamlphp_auth that referenced this issue May 12, 2023
@laryn
Issue backdrop-contrib#26: SimpleSAML authenticated admin users canno…
f9fcd56 
…t create other users.

Based on D7 work by Rich Burke (richburke), chrisgross, Cleber Gasparoto (chgasparoto), and Vitor Machado (vmachado).
@laryn laryn mentioned this issue May 12, 2023
Merged
@laryn
Copy link
Member Author

laryn commented May 12, 2023

PR has been submitted.

Tested the PR on a dev site by trying to create a new user after logging in via SimpleSAMLphp as an admin.

Before (duplicate entry lists admin email address):
image

After:
image

@laryn laryn closed this as completed in #31 May 16, 2023
laryn added a commit that referenced this issue May 16, 2023
@laryn
Issue #26: SimpleSAML authenticated admins cannot create other users. (…
34e52b4 
…#31)

Fixes #26.
Based on work by Rich Burke (richburke), chrisgross, Cleber Gasparoto (chgasparoto), Vitor Machado (vmachado), and Brian Osborne (bkosborne) in the Drupal 7 queue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #26: SimpleSAML authenticated admins cannot create other users. laryn/simplesamlphp_auth
1 participant
@laryn