Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the correct variables in simplesamlphp_auth_update_1000() #8

Closed
argiepiano opened this issue Nov 17, 2022 · 1 comment · Fixed by #12
Closed

Remove the correct variables in simplesamlphp_auth_update_1000() #8

argiepiano opened this issue Nov 17, 2022 · 1 comment · Fixed by #12

Comments

@argiepiano
Copy link

All the update_variable_del() calls in simplesamlphp_auth_update_1000() pass the wrong variable names to the delete function. For example, you want to delete simplesamlphp_auth_activate, not activate (which doesn't exist).

This means that all those D7 variables are kept in the database even after the upgrade.
@laryn
Copy link
Member

laryn commented Jan 16, 2023

👍 I noticed this, too, when looking at another issue.

laryn added a commit to laryn/simplesamlphp_auth that referenced this issue Jan 17, 2023
@laryn
Issue backdrop-contrib#8: Adjust variable names in update hook.
a63f417 
Fixes backdrop-contrib#8.
@laryn laryn mentioned this issue Jan 17, 2023
Merged
@laryn laryn closed this as completed in #12 May 16, 2023
laryn added a commit that referenced this issue May 16, 2023
@laryn
Issue #8: Adjust variable names in update hook.
c845226 
Fixes #8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #8: Adjust variable names in update hook. laryn/simplesamlphp_auth
2 participants
@laryn @argiepiano