-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONGOING] Keep jQuery 1.x and jQuery UI 1.x up to date. #2493
Comments
As we have dropped IE8 support, we could in theory upgrade to the latest jQuery (3.2.1 currently). Browser support listed here: http://jquery.com/browser-support/ But I think the bigger issue with upgrading to 3.x of jQuery is the deprecation of the I think upgrading to 3.x would be a Backdrop 2.x task, considering the scope of APIs changed there. However, I do think we should do our best to make Backdrop core jQuery 3.x compatible. |
We can still do minor updates for 1.8: jQuery: Already the latest version 1.12.4, but system_library() reports the version incorrectly as 1.11.0. (see #2826.) jQuery UI: Currently on 1.11.2. Can be upgraded to 1.12.1. |
Upgrading jQuery UI to 1.12.1 looks like it's a doozy, and probably not suitable for 1.8.0 at this point. Drupal accomplished this but it requires a large amount of manual repacking and reorganization. Issue is at https://www.drupal.org/node/2809427. We could adopt their reorganization, or consider just combining all the libraries together as was suggested earlier in that issue, which will make for much easier maintenance in the future. Filed an issue for fixing the version number of jQuery itself at #2826. |
Let's skip upgrading jQuery UI to 1.12.1 until we have time to thoroughly test it (bumping milestone to 1.9). I like the idea of easier maintenance in the future, so I'm all for combining all the libraries together. |
This issue wasn't updated when we last did a jQuery update, we are currently on Moving onto the 3.x version of jQuery (the current supported branch) is going to be a bit challenging. As it includes API breaks. I think we may need to do a combination of A) including the jQuery Migrate library for several releases and B) updating core's JS to not use any of the deprecated/removed functionality. We could remove jQuery Migrate either by |
I filed backdrop/backdrop#2175 to upgrade jQuery UI to the latest version. leveraging the Drupal patch this only required minor file renaming to get working. This will need much manual testing and review. Please try out the sandbox to check if everything works properly. Good candidates include CKEditor, Layout and Views UIs, and date elements. |
I've tested CKEditor and other places of the user interface manually without any problems. Afterwards I saw however a few related messages in the DBlog (see below). Here's what I did: CKEditor
Layout UI
Field UI
Date elements
Views UI
As I said, this worked without any problems. In the DBlog I saw however two jQuery related not found messages:
(There were also a |
Thanks @olafgrabienski! That's very helpful. I filed a new issue for that |
We're up-to-date on jQuery (1.x) and jQuery UI as of 1.11.0 release time. Updating to jQuery 3.x is still desirable but it would take some work to update our JS throughout core. |
...bumping to 1.13.0, since no new versions of jQuery 1.x or jQuery UI have been released. Also removed the "has PR", "needs review" and "needs feedback" tags. |
This time I try it via issue, as the forum post wasn't the right thing. My actual question is "hidden" in the last paragraph of that post:
So, how does jQuery UI get pulled in? Is there a special build tool or helper script, I'm not aware of? In Backdrop we have individual minified js files with filenames different from [jQuery UI sources, and in a different structure. How that? @quicksketch do you remember how you did it back in 2018? |
Related: #5705 |
jQuery Ui v1.13.3 was released last month: https://blog.jqueryui.com/2024/04/jquery-ui-1-13-3-released |
New issue created for jQuery UI 1.14.1: #6741 |
I think we should be keeping these two libraries up to date. Especially with minor releases of Backdrop CMS.
List of things to test each time we update:
Latest vs what we currently ship with is:
jQuery Core 1.12.4 / 1.11.0
jQuery UI 1.13.0 / 1.10.4
PS: it's been quite some time now that jQuery 2.x and 3.x are released. This is what I gathered from the net:
Perhaps now that we have decided to officially drop IE8 support (#214), we should upgrade to a version of jQuery that gets us speed improvements and smaller size. jQuery ninjas like @quicksketch are more qualified to tell if and how we'd benefit from such an update, so I leave it up to them.
The text was updated successfully, but these errors were encountered: