Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Status report page: show jQuery and jQuery UI as info instead of status. #3879

Open
klonos opened this issue Jun 21, 2019 · 5 comments · Fixed by backdrop/backdrop#2745

Comments

@klonos
Copy link
Member

klonos commented Jun 21, 2019

Current behavior:

Screen Shot 2019-06-22 at 5 12 31 am

Proposed change:

Screen Shot 2019-06-22 at 5 12 54 am

Reasoning: this belongs with the rest of the components that we simply need to communicate their version to the site admin. In D7, this was managed by contrib (https://www.drupal.org/project/jquery_update), and was configurable; whereas in Backdrop we ship an up to date, non-configurable version with core + we have a on-going issues to keep things up to date (#2493) + follow-up issues to update core to jQuery 2.x and eventually to 3.x (#3106).


PR by @klonos: backdrop/backdrop#2745

@klonos
Copy link
Member Author

klonos commented Jun 22, 2019

...while at it, I've:

  • fixed the website links for the jQuery UI libraries in system.module
  • removed duplicate library declaration for the "Scale" effect
  • made sure that ui.touch-punch is listed alphabetically
  • moved the jQuery version into the info description (makes it render collapsed, under a "more" link)
  • added info about all jQuery and jQuery UI plugins:

Collapsed:

Screen Shot 2019-06-22 at 12 03 56 pm

Expanded:

Screen Shot 2019-06-22 at 12 04 10 pm

@klonos
Copy link
Member Author

klonos commented Jun 22, 2019

...also:

  • made sure that all libraries in system_library_info() are listed alphabetically (better DX + easier to spot duplicate entries in the future)
  • made jQuery plugin labels links to the website of the respective plugin.

@quicksketch
Copy link
Member

quicksketch commented Jun 11, 2020

I wasn't sure quite what was happening with the code to make a list of every jQuery library's version, but now that I've seen the result, this seems genuinely useful. Code looks good to me too. Thanks @klonos for the PR and thanks @herbdool for reviewing!

I've merged backdrop/backdrop#2745 into 1.x and 1.16.x.

@quicksketch
Copy link
Member

I had to revert this commit because it seems that it has broken JS on some pages, such as the modules page (/admin/modules). Visiting that page, you'll get a JS error in the console that "jQuery is not defined".

Viewing the source, you see that the jquery.once library is loaded before jQuery itself is:

<script src="http://backdrop-core.lndo.site/core/misc/jquery.once.js?v=1.2.0"></script>
<script src="http://backdrop-core.lndo.site/core/misc/backdrop.js?v=1.16.x-dev"></script>
<script src="http://backdrop-core.lndo.site/core/misc/jquery.js?v=1.16.x-dev"></script>
<script src="http://backdrop-core.lndo.site/core/misc/jquery-extend-3.4.0.js?v=1.16.x-dev"></script>

Reopening and marking this as needs work.

@quicksketch quicksketch reopened this Jun 15, 2020
backdrop-ci referenced this issue in backdrop/backdrop Jun 15, 2020
…UI as info instead of status."

This reverts commit 619873a.
@quicksketch
Copy link
Member

Just a guess as to why this may have happened: it's possible that some libraries defined the same weight (such as -20). And reordering the libraries in system_library_info() may have caused the libraries to come out in different orders than before. I haven't checked this in-depth.

@jenlampton jenlampton modified the milestones: 1.17.4, 1.17.5 Nov 19, 2020
@quicksketch quicksketch modified the milestones: 1.17.5, 1.18.1 Jan 16, 2021
@jenlampton jenlampton modified the milestones: 1.18.1, 1.18.2 Jan 21, 2021
@jenlampton jenlampton modified the milestones: 1.18.2, 1.18.3 Mar 24, 2021
@jenlampton jenlampton modified the milestones: 1.18.3, 1.18.14 Apr 21, 2021
@jenlampton jenlampton modified the milestones: 1.18.4, 1.19.1 May 16, 2021
@jenlampton jenlampton modified the milestones: 1.19.1, 1.19.2 May 26, 2021
@quicksketch quicksketch modified the milestones: 1.19.2, 1.19.3 Jul 21, 2021
@jenlampton jenlampton modified the milestones: 1.19.3, 1.19.4 Aug 12, 2021
@quicksketch quicksketch modified the milestones: 1.19.4, 1.20.1 Sep 15, 2021
@quicksketch quicksketch modified the milestones: 1.20.1, 1.20.2 Oct 11, 2021
@jenlampton jenlampton modified the milestones: 1.20.2, 1.20.3 Nov 18, 2021
@quicksketch quicksketch modified the milestones: 1.20.3, 1.20.4 Dec 3, 2021
@herbdool herbdool removed this from the 1.20.4 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants