-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Status report page: show jQuery and jQuery UI as info instead of status. #3879
Comments
…UI as info instead of status backdrop/backdrop-issues#3879
...while at it, I've:
Collapsed: Expanded: |
...also:
|
I wasn't sure quite what was happening with the code to make a list of every jQuery library's version, but now that I've seen the result, this seems genuinely useful. Code looks good to me too. Thanks @klonos for the PR and thanks @herbdool for reviewing! I've merged backdrop/backdrop#2745 into 1.x and 1.16.x. |
I had to revert this commit because it seems that it has broken JS on some pages, such as the modules page (/admin/modules). Visiting that page, you'll get a JS error in the console that "jQuery is not defined". Viewing the source, you see that the jquery.once library is loaded before jQuery itself is:
Reopening and marking this as needs work. |
…UI as info instead of status." This reverts commit 619873a.
Just a guess as to why this may have happened: it's possible that some libraries defined the same weight (such as -20). And reordering the libraries in |
Current behavior:
Proposed change:
Reasoning: this belongs with the rest of the components that we simply need to communicate their version to the site admin. In D7, this was managed by contrib (https://www.drupal.org/project/jquery_update), and was configurable; whereas in Backdrop we ship an up to date, non-configurable version with core + we have a on-going issues to keep things up to date (#2493) + follow-up issues to update core to jQuery 2.x and eventually to 3.x (#3106).
PR by @klonos: backdrop/backdrop#2745
The text was updated successfully, but these errors were encountered: