Support WOFF 2.0 #34
Merged
Support WOFF 2.0 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| .DS_Store | |||
| node_modules | |||
| test/results | |||
| test/results* | |||
There was a problem hiding this comment.
What's the reason for this change?
There was a problem hiding this comment.
Your test code doesn't clean up results_css, results_less and results_scss when test failed. And test/results in .gitignore doesn't match these directories.
I think test should always be passed, but it's safer to ignore results* directories completely.
|
Thanks a lot, LGTM. The only question I have is with regards to the |
|
Sorry about the delay, thanks again! |
|
No problem! Thanks. |
|
Finally published as 2.1.0: https://github.com/backflip/gulp-iconfont-css/releases |
|
Thank you 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOFF 2.0 format is superior to WOFF, and
gulp-iconfontsupports it now.I added
woff2to the templates.And I found the master branch failed the test, so I also updated test assets to fix it.