-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: honor .global.postgresql.auth values #154
Conversation
3102f7d
to
bc09b13
Compare
cc @vinzscam @sabre1041 @ChrisJBurns Can you please take a look and let me know what you think? 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work
Approving but added a comment for your consideration
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
bc09b13
to
fa6237a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I get scared when I see postgres auth secret values getting changed 😆, mainly because of past stress of trying to satisfy all of the scenarios that tend to cause regression to other values if not done right. Do we have good tests to ensure that when certain values are set, the correct Deployment yaml is generated? As theres a few conditional branches in that I will add though, changes lgtm 👍 |
I don't have any tests at this time @ChrisJBurns . I've logged an issue to address this in future. I fully agree. 🙂 |
Description of the change
Our dependency - bitnami/postgresql chart has an option to configure
auth
viaglobal
scope variables. We do not consider that option when we infer secret name and key for the Backstage deployment volume mounts.This PR adds support for:
.Values.global.postgresql.auth.existingSecret
which overrides.Values.postgresql.auth.existingSecret
.Values.global.postgresql.auth.secretKeys.userPasswordKey
which overrides.Values.postgresql.auth.secretKeys.userPasswordKey
and (either of these) gets applied only if.Values.global.postgresql.auth.existingSecret
or.Values.postgresql.auth.existingSecret
is definedI'm using
()
chaining Helm?.
pipeline notation/workaround so I can avoid declaring those variables as''
invalues.yaml
Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-run
to preview the content.ct lint
command.