Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config visibility to the frontend #1828

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grantila
Copy link
Contributor

@grantila grantila commented Nov 5, 2024

SonarQube config visible in the frontend

We need to get the urls to the instances in the frontend, but they're not visible, despite being @visibility frontend in the config - although the backend config. I saw that there's a shadow config in the frontend package for the baseUrl, but this only works if you don't have multiple instances.

This PR adds the config values of the baseUrl (and other non-sensitive fields) to the frontend for multi-instance configurations.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Gustaf Räntilä <g.rantila@gmail.com>
@grantila grantila requested review from a team as code owners November 5, 2024 10:29
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-sonarqube workspaces/sonarqube/plugins/sonarqube patch v0.8.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant