GitHub Deployments Service Test schema missing variant

[calebcartwright]

Apparently the latest deployment status can be null while there is a deployment in progress,

which we account for within the service class schema accordingly:

shields/services/github/github-deployments.service.js

Lines 28 to 32 in ea24784

	latestStatus: Joi.alternatives([
	Joi.object({
	state: isDeploymentState,
	}),
	null,

However, our service tests do not:

shields/services/github/github-deployments.tester.js

Lines 6 to 15 in ea24784

	const validMessages = [
	'success',
	'error',
	'failure',
	'inactive',
	'in progress',
	'queued',
	'pending',
	]
	const isValidMessages = Joi.equal(...validMessages).required()

Ran into this earlier while trying to test a Dependabot PR while Dependabot/Repo Ranger were merging other PRs leading to shields-staging being deployed to during. I know this hasn't exactly been a frequent issue, but probably wouldn't hurt to make some tweaks, either by handling the null case more deliberately in the service class (for example, in what circumstance(s) does this occur and could we map the raw null to a more user-friendly badge message) or updating the service test validation schema

[dominikbrandon]

Hello there, I've just opened the PR addressing this issue - #5704. Please let me know if any further work will be necessary.

[homersimpsons]

Shouldn't this one be close as #5704 is merged?