Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Github] Handle the case when the Github deployment status returns null #5704

Merged
merged 3 commits into from
Oct 15, 2020
Merged

[Github] Handle the case when the Github deployment status returns null #5704

merged 3 commits into from
Oct 15, 2020

Conversation

dominikbrandon
Copy link
Contributor

@dominikbrandon dominikbrandon commented Oct 15, 2020 •
edited
Loading

This PR addresses an issue #5389

@dominikbrandon dominikbrandon marked this pull request as draft October 15, 2020 09:54
@shields-ci
Copy link

shields-ci commented Oct 15, 2020 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @dominikbrandon!

Generated by 🚫 dangerJS against 8ab1a91

@dominikbrandon dominikbrandon changed the title Handle the case when the Github deployment status returns null [Github] Handle the case when the Github deployment status returns null Oct 15, 2020
@dominikbrandon dominikbrandon marked this pull request as ready for review October 15, 2020 12:09
@dominikbrandon dominikbrandon mentioned this pull request Oct 15, 2020
Closed
@dominikbrandon
Copy link
Contributor Author

I did not find any information in the documentation about when does it return null in the latestStatus field. Therefore I assumed that it's empty just for a moment for new jobs and that the API will eventually return something else.

@calebcartwright calebcartwright added service-badge New or updated service badge keep-service-tests-green Related to fixing failing tests of the services labels Oct 15, 2020
@shields-cd shields-cd temporarily deployed to shields-staging-pr-5704 October 15, 2020 23:32 Inactive
calebcartwright
calebcartwright approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@repo-ranger repo-ranger bot merged commit d1ec834 into badges:master Oct 15, 2020
@github-actions
Copy link
Contributor

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@snyk-bot snyk-bot mentioned this pull request Sep 14, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
keep-service-tests-green Related to fixing failing tests of the services service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dominikbrandon @shields-ci @calebcartwright @shields-cd