-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HN (YCombinator's Hacker News) #7401
Comments
Thanks for sharing and including those details! Based on a cursory review it does seem like there should be some badges we could provide, though I've some skepticism of others based on textual warnings in the documentation. We have a really tight window in which to respond to our user requests for badges, and that typically limits our ability to make sequential API calls for data retrieval. So any data points that can be retrieved with a single call should be fine, but any that require a progressive call flow will most likely not be viable. |
If anybody hasn't picked this, I'd like to. |
Go for it @tapanchudasama! |
Created a PR for this => #7411 |
Nice! What about badge for the single post upvotes & post comments count?
|
Perhaps you'd be interested in submitting a PR yourself @Symbian9? Also, please note that those would most likely need to be separate badges (e.g. and ) as per our badge specification |
To be clear, I know nothing about such type of coding, so I just suggested/requested, because can't do it myself. |
I'll submit a PR for this, probably by Saturday. @Symbian9 |
Thanks! |
Raised A PR for
|
Thanks! What about HN-user profile details (karma) |
This was already mentioned above on this thread, but that already exists and is available for use https://img.shields.io/hackernews/user-karma/pg?style=social |
I see it is a little bit incorrect as it shows account name first letter capitalized — it should not; instead it should show letter case sensitive to HN website representation: Screenshot from HN website: |
I was doubtful about this while implementing also. |
JFTR, On HN some users has accounts with mixed letter cases: |
As a general note, I'd like to avoid using this one issue as a rolling feature request/bug tracker, so let's cap the scope of this issue to what's already been covered and address new items to separate, focused issues.
You're right that it's not right, but not for the right reason 😆 The default label should be Shields is responsible for the rendering concerns and the way our badges look, while upstream platforms are simply the sources of data. We do not base our presentation/rendering concerns based on what other platforms do. The history and rationale for this is captured in places throughout the repo (e.g. https://github.com/badges/shields#history) So casing differences between how we display labels vs. HNs displays is irrelevant |
I did not quite understand @calebcartwright 🤔 . Something that I missed? |
This is not about how "HN displays" — here I pointing out to the state that HN user accounts names are casesensitive as users set them (the same way as on Twitter): Both URLs are correct: But there is |
No worries, we missed it on follow up review too - #7411 (comment) |
It's not clear to me what exactly you are arguing for/against given the above, particularly this from #7401 (comment)
I.e., it's a bit moot given what the label value is supposed to be. However, as far as I know, the user profile names aren't actually case sensitive, The fact that a platform (Twitter or HackerNews) supports displaying the same profile in different casing is, unequivocally, orthogonal to (a) what our default badge label should be for any/all of our HN-based badges, and (b) the fact that we always upper case the first character in the label on social badges. I'm not personally very receptive to the possibility of supporting additional customization on label casing in our social style, because even for those that feel strongly about the casing, badges of the E.g. would mean what? there's some 6.6 thousand app4softs? 😆 However, if you think you need the ability to have a social-styled label with casing you control, that's a completely separate request that needs to be discussed in a separate issue (and again which I don't see being likely to come to fruition) |
No, you just misinterpreted HN account URL with HN account username/registered name: For example on Twitter, both BUT on Twitter, as on HN, account cast URL shown exactly as user set it during registration, i.e. casesensitive ANYWAY, Capitalizing first letters in linked account on shields badge, ignoring user input name with lowercase first letter, is NOT permitted. Addition
@calebcartwright, if so, would mean there are 409 app4softs on Twitter UPDATE@tapanchudasama, I guess HN user profile badge should not include user name, but just represent "HN Karma":
|
@Symbian9 -
Let's check the tone here. We, as the maintainers of this service, amongst other responsibilities, ensure adherence to the project's goals, and that includes the styles we provide and consistent defaults across our badges. Those are not dictated based on the "Website representation" of an upstream service, nor any individual user. You do not get to determine what is "permitted" here, period. Your comments also give me the impression that you haven't actually taken the time to read and process the previous comments nor linked material, but instead are continuing to issue instruction instead. That is increasingly leading to this thread getting off topic, and this needs to be the end of it. You're free to continue participating constructively in the discussion/ask questions/etc., but any additional comments with the same type of tone are going to be hidden/removed, and I'll lock the thread if if becomes necessary.
Again, it seems you're too busy telling us what to do instead of reading and processing what's been said. As already stated previously (emphasis added):
You will notice in your own example that the first character in those twitter badges is the https://img.shields.io/twitter/follow/espadrine?label=espadrine&style=social
No, not at all. The Twitter Followers badge is poor counter argument, especially because it has the context about the "what" in the label: the word "Follow" clearly denotes that the badge is talking about followers/following. It has that extra context because unlike the badges you've requested for HN, it's an "actionable" badge where the message is clickable with an embedded link to start following the user. Conversely, doesn't actually have any context. Does it mean 6.6k submissions/posts? karma? something else? There's no way to know definitively from the badge itself/it's entirely subjective. That's why we have our aforementioned badge specification to define our defaults, and that's why there is indeed a need to change the current default label as has already been discussed. Any additional debate about using the id as the default label, or the first character casing in our social style, is futile at this point, so I anticipate this being my last comment on the subject. However, I will recap the options that will already be available/pursuable if you'd still like to include the id in a case-sensitive manner in the badge label:
|
Yes, that is karma. I tell that in the header comment and clarified it few more times in next comments. Offtopic
To be clear, I'm not trying to be rude here, but " 6.6 thousand app4softs?" was not a funny joke. |
What I think @Symbian9 means is this:
What I think can be done:
WDYT @calebcartwright ? |
We need to change the label, and do so ASAP, but no the style needs to remain social as-is. If you're up for working on that'd be great (feel free to use a reaction to indicate if so)! The exact value can be discussed on a PR, but please note that it needs to be based on the direction of the maintainers and our badge specification, which does not allow for promotional/branding (i.e. no The current labeling, and the labeling @Symbian9 has been insisting on debating thus far, fails to pass those gates which is why we need to do something different than both those demands and what is out there currently. Specifically, the problem with the current label is that if one were to go to https://img.shields.io/hackernews/user-karma/app4soft?style=social&label=app4soft or see 👇 rendered on a readme or some other page, it's not self-evident to the reader what it means (even though the author who put it there knows) |
@Symbian9 - thanks again for your original suggest/request for some HN badges. I think they'll prove a worthwhile edition in a similar vein as the reddit badges. Unfortunately, however, you seem intent on trying to keep this a 1-directional discussion where you're simply talking at everyone else. I appreciate that users get frustrated when they don't get the answers they want, but that doesn't mean the thread should have been detoured into the non-productive territory we currently find ourselves in. Information has already been provided above about what we need and why, as well as why the answer was a "no" to your repeated requests/direction, including the ones that are off topic. There's no point in continuing to run in circles on that any more. As such, I'm going to close the issue at this time because (a) the specific badge requests have already been received and are already completed or in-flight, and (b) the dialog has devolved far too much past the point of utility. |
📋 Description
A clear and concise description of the new badge.
🔗 Data
🎤 Motivation
REFERENCE
There are few other related projects:
The text was updated successfully, but these errors were encountered: