Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HN (YCombinator's Hacker News) #7401

Closed
ghost opened this issue Dec 19, 2021 · 27 comments
Closed

HN (YCombinator's Hacker News) #7401

ghost opened this issue Dec 19, 2021 · 27 comments
Labels
service-badge Accepted and actionable changes, features, and bugs

Comments

@ghost
Copy link

ghost commented Dec 19, 2021

📋 Description

A clear and concise description of the new badge.

🔗 Data

🎤 Motivation

  • What is the specific use case?
    • Add info about user in readme on GitHub & other sites.

REFERENCE

There are few other related projects:

@ghost ghost added the service-badge Accepted and actionable changes, features, and bugs label Dec 19, 2021
@calebcartwright
Copy link
Member

Thanks for sharing and including those details! Based on a cursory review it does seem like there should be some badges we could provide, though I've some skepticism of others based on textual warnings in the documentation. We have a really tight window in which to respond to our user requests for badges, and that typically limits our ability to make sequential API calls for data retrieval.

So any data points that can be retrieved with a single call should be fine, but any that require a progressive call flow will most likely not be viable.

@tapanchudasama
Copy link
Contributor

If anybody hasn't picked this, I'd like to.

@calebcartwright
Copy link
Member

Go for it @tapanchudasama!

@tapanchudasama
Copy link
Contributor

Created a PR for this => #7411

@ghost
Copy link
Author

ghost commented Dec 22, 2021

Created a PR for this [User name & user karma]

Nice!

What about badge for the single post upvotes & post comments count?

@calebcartwright
Copy link
Member

Created a PR for this [User name & user karma]

Nice!

What about badge for the single post upvotes & post comments count?

* Example: https://news.ycombinator.com/item?id=21462689 (`Shields.io` discussion thread on HN)
  
  * `109 points | 10 comments`

Perhaps you'd be interested in submitting a PR yourself @Symbian9? Also, please note that those would most likely need to be separate badges (e.g. and ) as per our badge specification

@ghost
Copy link
Author

ghost commented Jan 1, 2022

Perhaps you'd be interested in submitting a PR yourself @Symbian9?

To be clear, I know nothing about such type of coding, so I just suggested/requested, because can't do it myself.

@tapanchudasama
Copy link
Contributor

I'll submit a PR for this, probably by Saturday. @Symbian9

@ghost
Copy link
Author

ghost commented Jan 6, 2022

Thanks!

@tapanchudasama
Copy link
Contributor

tapanchudasama commented Jan 7, 2022

I'll submit a PR for this, probably by Saturday. @Symbian9

Raised A PR for

@ghost
Copy link
Author

ghost commented Jan 7, 2022

Raised A PR for

Thanks! What about HN-user profile details (karma)

@calebcartwright
Copy link
Member

Thanks! What about HN-user profile details (karma)

This was already mentioned above on this thread, but that already exists and is available for use

https://img.shields.io/hackernews/user-karma/pg?style=social

@ghost
Copy link
Author

ghost commented Jan 7, 2022

This was already mentioned above on this thread, but that already exists and is available for use

I see it is a little bit incorrect as it shows account name first letter capitalized — it should not; instead it should show letter case sensitive to HN website representation:

  • Actual: App4soft
  • Expected: app4soft

Screenshot from HN website:

Screenshot_2022-01-07_19-04-33

@tapanchudasama
Copy link
Contributor

I was doubtful about this while implementing also. pg which is in smallcase also comes capitalised. Should we do something about this? @calebcartwright

@ghost
Copy link
Author

ghost commented Jan 7, 2022

JFTR, On HN some users has accounts with mixed letter cases:

@calebcartwright
Copy link
Member

As a general note, I'd like to avoid using this one issue as a rolling feature request/bug tracker, so let's cap the scope of this issue to what's already been covered and address new items to separate, focused issues.

I see it is a little bit incorrect as it shows account name first letter capitalized

You're right that it's not right, but not for the right reason 😆 The default label should be Karma, as was discussed in the PR (not sure how that slipped through!). If users want to change the label value then they can do so via the ?label=foo query parameter.

Shields is responsible for the rendering concerns and the way our badges look, while upstream platforms are simply the sources of data. We do not base our presentation/rendering concerns based on what other platforms do. The history and rationale for this is captured in places throughout the repo (e.g. https://github.com/badges/shields#history)

So casing differences between how we display labels vs. HNs displays is irrelevant

@tapanchudasama
Copy link
Contributor

The default label should be Karma, as was discussed in the PR (not sure how that slipped through!).

I did not quite understand @calebcartwright 🤔 . Something that I missed?

@ghost
Copy link
Author

ghost commented Jan 7, 2022

We do not base our presentation/rendering concerns based on what other platforms do

So casing differences between how we display labels vs. HNs displays is irrelevant

This is not about how "HN displays" — here I pointing out to the state that HN user accounts names are casesensitive as users set them (the same way as on Twitter):

Both URLs are correct:

But there is ColinWright name shown casesensitive on both pages the same.

@calebcartwright
Copy link
Member

The default label should be Karma, as was discussed in the PR (not sure how that slipped through!).

I did not quite understand @calebcartwright thinking . Something that I missed?

No worries, we missed it on follow up review too - #7411 (comment)

@calebcartwright
Copy link
Member

This is not about how "HN displays" — here I pointing out to the state that HN user accounts names are casesensitive as users set them (the same way as on Twitter):

It's not clear to me what exactly you are arguing for/against given the above, particularly this from #7401 (comment)

The default label should be Karma, as was discussed in the PR (not sure how that slipped through!)

I.e., it's a bit moot given what the label value is supposed to be. However, as far as I know, the user profile names aren't actually case sensitive, colinwright and ColinWright are not distinct human profiles, but are instead the same account.

The fact that a platform (Twitter or HackerNews) supports displaying the same profile in different casing is, unequivocally, orthogonal to (a) what our default badge label should be for any/all of our HN-based badges, and (b) the fact that we always upper case the first character in the label on social badges.

I'm not personally very receptive to the possibility of supporting additional customization on label casing in our social style, because even for those that feel strongly about the casing, badges of the username | metric variety really don't make much sense as there's zero context.

E.g. would mean what? there's some 6.6 thousand app4softs? 😆

However, if you think you need the ability to have a social-styled label with casing you control, that's a completely separate request that needs to be discussed in a separate issue (and again which I don't see being likely to come to fruition)

@ghost
Copy link
Author

ghost commented Jan 7, 2022

colinwright and ColinWright are not distinct human profiles, but are instead the same account.

No, you just misinterpreted HN account URL with HN account username/registered name:

Screenshot_2022-01-07_22-46-46

For example on Twitter, both @karibyron & @KariByron are valid cast URL:

  • @KariByron
  • @karibyron

BUT on Twitter, as on HN, account cast URL shown exactly as user set it during registration, i.e. casesensitive @KariByron:

ANYWAY, Capitalizing first letters in linked account on shields badge, ignoring user input name with lowercase first letter, is NOT permitted.

Addition

E.g. would mean what? there's some 6.6 thousand app4softs? laughing

@calebcartwright, if so, would mean there are 409 app4softs on Twitter

UPDATE

@tapanchudasama, I guess HN user profile badge should not include user name, but just represent "HN Karma":

  • [Y] HN Karma {<user_karma_points>}

@calebcartwright
Copy link
Member

@Symbian9 -

ANYWAY, Capitalizing first letters in linked account on shields badge, ignoring user input name with lowercase first letter, is NOT permitted.

Let's check the tone here.

We, as the maintainers of this service, amongst other responsibilities, ensure adherence to the project's goals, and that includes the styles we provide and consistent defaults across our badges. Those are not dictated based on the "Website representation" of an upstream service, nor any individual user. You do not get to determine what is "permitted" here, period.

Your comments also give me the impression that you haven't actually taken the time to read and process the previous comments nor linked material, but instead are continuing to issue instruction instead. That is increasingly leading to this thread getting off topic, and this needs to be the end of it. You're free to continue participating constructively in the discussion/ask questions/etc., but any additional comments with the same type of tone are going to be hidden/removed, and I'll lock the thread if if becomes necessary.

For example on Twitter, both @karibyron & @KariByron are valid cast URL:

Again, it seems you're too busy telling us what to do instead of reading and processing what's been said. As already stated previously (emphasis added):

we always upper case the first character in the label on social badges.

You will notice in your own example that the first character in those twitter badges is the F in the word "Follow", and that is, indeed, capitalized. It does not start with the user's handle by default. However, if you were to customize the label to only include the handle, you'd see the same behavior.

https://img.shields.io/twitter/follow/espadrine?label=espadrine&style=social

@calebcartwright, if so, would mean there are 409 app4softs on Twitter

No, not at all. The Twitter Followers badge is poor counter argument, especially because it has the context about the "what" in the label: the word "Follow" clearly denotes that the badge is talking about followers/following. It has that extra context because unlike the badges you've requested for HN, it's an "actionable" badge where the message is clickable with an embedded link to start following the user.

Conversely, doesn't actually have any context. Does it mean 6.6k submissions/posts? karma? something else? There's no way to know definitively from the badge itself/it's entirely subjective. That's why we have our aforementioned badge specification to define our defaults, and that's why there is indeed a need to change the current default label as has already been discussed.

Any additional debate about using the id as the default label, or the first character casing in our social style, is futile at this point, so I anticipate this being my last comment on the subject. However, I will recap the options that will already be available/pursuable if you'd still like to include the id in a case-sensitive manner in the badge label:

@ghost
Copy link
Author

ghost commented Jan 8, 2022

Does it mean 6.6k submissions/posts? karma?

Yes, that is karma. I tell that in the header comment and clarified it few more times in next comments.

Offtopic

Let's check the tone here.

To be clear, I'm not trying to be rude here, but " 6.6 thousand app4softs?" was not a funny joke.

@tapanchudasama
Copy link
Contributor

What I think @Symbian9 means is this:

  • The Pg in the badge https://img.shields.io/hackernews/user-karma/pg is actually the username of the person in HN. And that is casesensitive. So for username pg and username Pg, out badges are same, which should not be the case. Right, @Symbian9 ?

What I think can be done:

  • Not make the style social
  • Keep style social and not show username, but just HN Karma instead.

WDYT @calebcartwright ?

@ghost
Copy link
Author

ghost commented Jan 8, 2022

And that is casesensitive. So for username pg and username Pg, out badges are same, which should not be the case. Right, @Symbian9?

Not exactly.

Keep style social and not show username, but just HN Karma instead.

Yes, that is what I mean for https://img.shields.io/hackernews/user-karma/<id> — there shold be NO name of user shown in a badge at all.

Instead "user-karma" badge should be shown as next: <site-ico> HN Karma <karma-points>

Not make the style social

Why not? It may look correctly like next:

  • example

As on HN there are no any other counters than Karma points, which are a result of upvotes given to user posts, that is exactly what social is on HN.

Alternatively, represent HN karma as Reddit karma:

  • [R] u/app4soft karma] - https://img.shields.io/reddit/user-karma/combined/app4soft?style=social)
  • [Y] HN/app4soft karma - https://img.shields.io/hackernews/user-karma/app4soft?style=social

Side not: on Reddit user karma badge U/<user-id> also looks a bit wrong by autocapitalized 1st letter — it should look as u/<user-id> instead.

@calebcartwright
Copy link
Member

@tapanchudasama

WDYT @calebcartwright ?

We need to change the label, and do so ASAP, but no the style needs to remain social as-is. If you're up for working on that'd be great (feel free to use a reaction to indicate if so)!

The exact value can be discussed on a PR, but please note that it needs to be based on the direction of the maintainers and our badge specification, which does not allow for promotional/branding (i.e. no HN, no HackerNews), and must have self-evident semantics.

The current labeling, and the labeling @Symbian9 has been insisting on debating thus far, fails to pass those gates which is why we need to do something different than both those demands and what is out there currently.

Specifically, the problem with the current label is that if one were to go to https://img.shields.io/hackernews/user-karma/app4soft?style=social&label=app4soft

or see 👇 rendered on a readme or some other page, it's not self-evident to the reader what it means (even though the author who put it there knows)

@calebcartwright
Copy link
Member

@Symbian9 - thanks again for your original suggest/request for some HN badges. I think they'll prove a worthwhile edition in a similar vein as the reddit badges.

Unfortunately, however, you seem intent on trying to keep this a 1-directional discussion where you're simply talking at everyone else. I appreciate that users get frustrated when they don't get the answers they want, but that doesn't mean the thread should have been detoured into the non-productive territory we currently find ourselves in.

Information has already been provided above about what we need and why, as well as why the answer was a "no" to your repeated requests/direction, including the ones that are off topic. There's no point in continuing to run in circles on that any more.

As such, I'm going to close the issue at this time because (a) the specific badge requests have already been received and are already completed or in-flight, and (b) the dialog has devolved far too much past the point of utility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

No branches or pull requests

2 participants